superrob1500
/
mirror-Windows-Sandbox-Tools
mirror of https://github.com/ThioJoe/Windows-Sandbox-Tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

replace Expand-Archive with .NET ZipFile for Sandbox stability 

The `Expand-Archive` cmdlet fails in localized Windows Sandbox environments (e.g., de-DE) because the `Microsoft.PowerShell.Archive` module cannot find its localization resources (`ArchiveResources.psd1`) in the minimal OS image.

Changes:
- Replaced `Expand-Archive` with `[System.IO.Compression.ZipFile]::ExtractToDirectory`
- Added `Add-Type -AssemblyName System.IO.Compression.FileSystem` to ensure .NET zip support
- Added a safety check to ensure the Downloads directory exists
pull/16/head
Jean-Luc Tcharnetsky 2025-12-18 16:15:56 +01:00 committed by GitHub
parent c33a3c70b7
commit 8095a09a7a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Installer Scripts/Install-Winget.ps1
View File

@ -81,6 +81,7 @@ function Install-WingetDependencies {
$ProgressPreference = 'SilentlyContinue' $ProgressPreference = 'SilentlyContinue'
$downloadPath = Join-Path $env:USERPROFILE "Downloads" $downloadPath = Join-Path $env:USERPROFILE "Downloads"
if (!(Test-Path $downloadPath)) { New-Item -ItemType Directory -Path $downloadPath }
$latestRelease = Get-LatestRelease $latestRelease = Get-LatestRelease
if (-not $latestRelease) { Write-Error "Could not retrieve the latest release. Exiting."; return; } if (-not $latestRelease) { Write-Error "Could not retrieve the latest release. Exiting."; return; }
@ -125,8 +126,10 @@ if ($depsZipUrl) {
# Remove existing Dependencies folder and expand the zip # Remove existing Dependencies folder and expand the zip
if (Test-Path $topDepsFolder) { Remove-Item -Path $topDepsFolder -Recurse -Force } if (Test-Path $topDepsFolder) { Remove-Item -Path $topDepsFolder -Recurse -Force }
Expand-Archive -LiteralPath $depsZipPath -DestinationPath $topDepsFolder -Force # Replaces Expand archives with .NET System.IO.Compression
Add-Type -AssemblyName System.IO.Compression.FileSystem
[System.IO.Compression.ZipFile]::ExtractToDirectory($depsZipPath, $topDepsFolder)
} }
else { Write-Warning "No $depsZipName found in $latestTag, skipping dependency download."; } else { Write-Warning "No $depsZipName found in $latestTag, skipping dependency download."; }
@ -156,4 +159,3 @@ if ($removeMsStoreAsSource.IsPresent) {
# Automatically accept source agreements to avoid prompts. Mostly applies to msstore. # Automatically accept source agreements to avoid prompts. Mostly applies to msstore.
winget list --accept-source-agreements | Out-Null winget list --accept-source-agreements | Out-Null
} }