superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GTK: followup update search state on activation (#9766) 

followup from comment in this PR
https://github.com/ghostty-org/ghostty/pull/9765
pull/9777/head
Mitchell Hashimoto 2025-12-01 07:25:45 -08:00 committed by GitHub
parent 2a9a57daff 27c82f739e
commit 09f7e38b45
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/apprt/gtk/class/search_overlay.zig
View File

@ -43,7 +43,14 @@ pub const SearchOverlay = extern struct {
bool,
.{
.default = false,
.accessor = C.privateShallowFieldAccessor("active"),
.accessor = gobject.ext.typedAccessor(
Self,
bool,
.{
.getter = getSearchActive,
.setter = setSearchActive,
},
),
},
);
};
@ -231,10 +238,16 @@ pub const SearchOverlay = extern struct {
// Select all text in the search entry field. -1 is distance from
// the end, causing the entire text to be selected.
priv.search_entry.as(gtk.Editable).selectRegion(0, -1);
}
// update search state with the active text
const text = priv.search_entry.as(gtk.Editable).getText();
signals.@"search-changed".impl.emit(self, null, .{text}, null);
// Set active status, and update search on activation
fn setSearchActive(self: *Self, active: bool) void {
const priv = self.private();
if (!priv.active and active) {
const text = priv.search_entry.as(gtk.Editable).getText();
signals.@"search-changed".impl.emit(self, null, .{text}, null);
}
priv.active = active;
}
/// Set the total number of search matches.
@ -261,6 +274,10 @@ pub const SearchOverlay = extern struct {
}
}
fn getSearchActive(self: *Self) bool {
return self.private().active;
}
fn getSearchTotal(self: *Self) u64 {
return self.private().search_total orelse 0;
}

1
src/apprt/gtk/class/surface.zig
View File

@ -1964,6 +1964,7 @@ pub const Surface = extern struct {
SearchOverlay.properties.active.name,
&value,
);
if (active) {
priv.search_overlay.grabFocus();
}