macos: address remaining todos
parent
6c97e4a59a
commit
19a9156ae1
|
|
@ -405,7 +405,7 @@ class BaseTerminalController: NSWindowController,
|
|||
// If splitting fails for any reason (it should not), then we just log
|
||||
// and return. The new view we created will be deinitialized and its
|
||||
// no big deal.
|
||||
// TODO: log
|
||||
Ghostty.logger.warning("failed to insert split: \(error)")
|
||||
return
|
||||
}
|
||||
|
||||
|
|
@ -559,7 +559,7 @@ class BaseTerminalController: NSWindowController,
|
|||
do {
|
||||
surfaceTree = try surfaceTree.replace(node: node, with: resizedNode)
|
||||
} catch {
|
||||
// TODO: log
|
||||
Ghostty.logger.warning("failed to replace node during split resize: \(error)")
|
||||
return
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -152,7 +152,7 @@ class TerminalController: BaseTerminalController {
|
|||
|
||||
// If we have no surfaces in our window (is that possible?) then we update
|
||||
// our window appearance based on the root config. If we have surfaces, we
|
||||
// don't call this because the TODO
|
||||
// don't call this because focused surface changes will trigger appearance updates.
|
||||
if surfaceTree.isEmpty {
|
||||
syncAppearance(.init(config))
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue