superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

macos: for windowShouldClose, only close the tab if we have multiple 

Fixes a regression from our undo/redo rework. We were accidentally
closing the entire window when the "X" button in the tab bar was
clicked.
pull/7566/head
Mitchell Hashimoto 2025-06-10 12:39:09 -07:00
parent 8b5cceed3e
commit 1f340b4b2d
No known key found for this signature in database
GPG Key ID: 523D5DC389D273BC
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
macos/Sources/Features/Terminal/TerminalController.swift
View File

@ -1046,7 +1046,12 @@ class TerminalController: BaseTerminalController {
//MARK: - NSWindowDelegate //MARK: - NSWindowDelegate
override func windowShouldClose(_ sender: NSWindow) -> Bool { override func windowShouldClose(_ sender: NSWindow) -> Bool {
closeWindow(sender) // If we have tabs, then this should only close the tab.
if window?.tabGroup?.windows.count ?? 0 > 1 {
closeTab(sender)
} else {
closeWindow(sender)
}
// We will always explicitly close the window using the above // We will always explicitly close the window using the above
return false return false