some PR feedback

pull/8895/head
Mitchell Hashimoto 2025-09-24 12:24:47 -07:00
parent 513cdf667b
commit 48827b21d8
No known key found for this signature in database
GPG Key ID: 523D5DC389D273BC
4 changed files with 6 additions and 12 deletions

View File

@ -104,8 +104,6 @@ pub fn build(b: *std.Build) !void {
);
libghostty_vt_shared.install(libvt_step);
libghostty_vt_shared.install(b.getInstallStep());
libghostty_vt_shared.installPkgConfig(libvt_step);
libghostty_vt_shared.installPkgConfig(b.getInstallStep());
// Helpgen
if (config.emit_helpgen) deps.help_strings.install();

View File

@ -3,7 +3,9 @@
int main() {
GhosttyOscParser parser;
ghostty_vt_osc_new(NULL, &parser);
if (ghostty_vt_osc_new(NULL, &parser) != GHOSTTY_VT_SUCCESS) {
return 1;
}
ghostty_vt_osc_free(parser);
return 0;
}

View File

@ -15,9 +15,9 @@
extern "C" {
#endif
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>
#include <stdbool.h>
//-------------------------------------------------------------------
// Types
@ -178,7 +178,7 @@ typedef struct {
* @param parser Pointer to store the created parser handle
* @return GHOSTTY_VT_SUCCESS on success, or an error code on failure
*/
GhosttyVtResult ghostty_vt_osc_new(const GhosttyVtAllocator* allocator, GhosttyOscParser* parser);
GhosttyVtResult ghostty_vt_osc_new(const GhosttyVtAllocator *allocator, GhosttyOscParser *parser);
/**
* Free an OSC parser instance.

View File

@ -76,15 +76,9 @@ pub fn initShared(
pub fn install(
self: *const GhosttyLibVt,
step: *std.Build.Step,
) void {
step.dependOn(&self.artifact.step);
}
pub fn installPkgConfig(
self: *const GhosttyLibVt,
step: *std.Build.Step,
) void {
const b = step.owner;
step.dependOn(&self.artifact.step);
step.dependOn(&b.addInstallFileWithDir(
self.pkg_config,
.prefix,