superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf: remove some overzealous inline annotations 

These were actually hurting performance lol, except in the places where
I added the `.always_inline` calls- for some reason if these functions
aren't inlined there it really messes up the top region scrolling
benchmark in vtebench and I'm not entirely certain why...
pull/9645/head
Qwerasd 2025-11-19 12:37:09 -07:00
parent 0ce3d0bd07
commit 7d89aa764d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/terminal/page.zig
View File

@ -1058,7 +1058,7 @@ pub const Page = struct {
if (row.grapheme) { if (row.grapheme) {
for (cells) |*cell| { for (cells) |*cell| {
if (cell.hasGrapheme()) if (cell.hasGrapheme())
self.clearGrapheme(cell); @call(.always_inline, clearGrapheme, .{ self, cell });
} }
// If we have no left/right scroll region we can be sure // If we have no left/right scroll region we can be sure
@ -1074,7 +1074,7 @@ pub const Page = struct {
if (row.hyperlink) { if (row.hyperlink) {
for (cells) |*cell| { for (cells) |*cell| {
if (cell.hyperlink) if (cell.hyperlink)
self.clearHyperlink(cell); @call(.always_inline, clearHyperlink, .{ self, cell });
} }
// If we have no left/right scroll region we can be sure // If we have no left/right scroll region we can be sure
@ -1132,7 +1132,7 @@ pub const Page = struct {
/// In order to update the hyperlink flag on the row, call /// In order to update the hyperlink flag on the row, call
/// `updateRowHyperlinkFlag` after you finish clearing any /// `updateRowHyperlinkFlag` after you finish clearing any
/// hyperlinks in the row. /// hyperlinks in the row.
pub inline fn clearHyperlink(self: *Page, cell: *Cell) void { pub fn clearHyperlink(self: *Page, cell: *Cell) void {
defer self.assertIntegrity(); defer self.assertIntegrity();
// Get our ID // Get our ID
@ -1468,7 +1468,7 @@ pub const Page = struct {
/// In order to update the grapheme flag on the row, call /// In order to update the grapheme flag on the row, call
/// `updateRowGraphemeFlag` after you finish clearing any /// `updateRowGraphemeFlag` after you finish clearing any
/// graphemes in the row. /// graphemes in the row.
pub inline fn clearGrapheme(self: *Page, cell: *Cell) void { pub fn clearGrapheme(self: *Page, cell: *Cell) void {
defer self.assertIntegrity(); defer self.assertIntegrity();
if (build_options.slow_runtime_safety) assert(cell.hasGrapheme()); if (build_options.slow_runtime_safety) assert(cell.hasGrapheme());