superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

input: "ignore" binding action are still be processed by the OS/GUI 

Related to #7468

This changes the behavior of "ignore". Previously, Ghostty would
consider "ignore" actions consumed but do nothing. They were like a
black hole. Now, Ghostty returns `ignored` which lets the apprt forward
the event to the OS/GUI.

This enables keys that would otherwise be pty-encoded to be processed
later, such as for GTK to show the GTK inspector.
pull/7474/head
Mitchell Hashimoto 2025-05-29 16:03:01 -07:00
parent d94bcda778
commit 891b23917b
No known key found for this signature in database
GPG Key ID: 523D5DC389D273BC
2 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Surface.zig
View File

@ -2069,12 +2069,18 @@ fn maybeHandleBinding(
break :performed try self.performBindingAction(action); break :performed try self.performBindingAction(action);
}; };
// If we performed an action and it was a closing action, if (performed) {
// our "self" pointer is not safe to use anymore so we need to // If we performed an action and it was a closing action,
// just exit immediately. // our "self" pointer is not safe to use anymore so we need to
if (performed and closingAction(action)) { // just exit immediately.
log.debug("key binding is a closing binding, halting key event processing", .{}); if (closingAction(action)) {
return .closed; log.debug("key binding is a closing binding, halting key event processing", .{});
return .closed;
}
// If our action was "ignore" then we return the special input
// effect of "ignored".
if (action == .ignore) return .ignored;
} }
// If we have the performable flag and the action was not performed, // If we have the performable flag and the action was not performed,

11
src/input/Binding.zig
View File

@ -222,13 +222,20 @@ pub fn lessThan(_: void, lhs: Binding, rhs: Binding) bool {
/// The set of actions that a keybinding can take. /// The set of actions that a keybinding can take.
pub const Action = union(enum) { pub const Action = union(enum) {
/// Ignore this key combination, don't send it to the child process, just /// Ignore this key combination, don't send it to the child process,
/// black hole it. /// pretend that it never happened at the Ghostty level. The key
/// combination may still be processed by the OS or other
/// applications.
ignore, ignore,
/// This action is used to flag that the binding should be removed from /// This action is used to flag that the binding should be removed from
/// the set. This should never exist in an active set and `set.put` has an /// the set. This should never exist in an active set and `set.put` has an
/// assertion to verify this. /// assertion to verify this.
///
/// This is only able to unbind bindings that were previously
/// bound to Ghostty. This cannot unbind bindings that were not
/// bound by Ghostty (e.g. bindings set by the OS or some other
/// application).
unbind, unbind,
/// Send a CSI sequence. The value should be the CSI sequence without the /// Send a CSI sequence. The value should be the CSI sequence without the