lint all Yaml files

pull/577/head
Patrick Fong 2023-09-28 10:42:38 -07:00
parent 8be80558c7
commit 9d2a85d9cd
5 changed files with 194 additions and 195 deletions

View File

@ -2,16 +2,16 @@ name: Clean Artifacts
on: on:
schedule: schedule:
# Once a day # Once a day
- cron: '0 0 * * *' - cron: "0 0 * * *"
workflow_dispatch: workflow_dispatch:
jobs: jobs:
remove-old-artifacts: remove-old-artifacts:
runs-on: ubuntu-latest runs-on: ubuntu-latest
timeout-minutes: 10 timeout-minutes: 10
steps: steps:
- name: Remove old artifacts - name: Remove old artifacts
uses: c-hive/gha-remove-artifacts@v1 uses: c-hive/gha-remove-artifacts@v1
with: with:
age: '1 week' age: "1 week"
skip-tags: true skip-tags: true
skip-recent: 5 skip-recent: 5

View File

@ -13,13 +13,13 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: [build-macos] needs: [build-macos]
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- name: Tip Tag - name: Tip Tag
run: | run: |
git config user.name "GitHub Actions Bot" git config user.name "GitHub Actions Bot"
git config user.email "<>" git config user.email "<>"
git tag -fa tip -m "Latest Continuous Release" ${GITHUB_SHA} git tag -fa tip -m "Latest Continuous Release" ${GITHUB_SHA}
git push --force origin tip git push --force origin tip
build-macos: build-macos:
if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }} if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }}
@ -29,130 +29,130 @@ jobs:
# Needed for macos SDK # Needed for macos SDK
AGREE: "true" AGREE: "true"
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v4 uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
fetch-depth: 0 fetch-depth: 0
# Install Nix and use that to run our tests so our environment matches exactly. # Install Nix and use that to run our tests so our environment matches exactly.
- uses: cachix/install-nix-action@v23 - uses: cachix/install-nix-action@v23
with: with:
nix_path: nixpkgs=channel:nixos-unstable nix_path: nixpkgs=channel:nixos-unstable
# Setup our S3 client # Setup our S3 client
- name: Setup s3cmd - name: Setup s3cmd
uses: s3-actions/s3cmd@v1.5.0 uses: s3-actions/s3cmd@v1.5.0
with: with:
provider: cloudflare provider: cloudflare
account_id: ${{ secrets.CF_R2_TIP_ACCOUNT_ID }} account_id: ${{ secrets.CF_R2_TIP_ACCOUNT_ID }}
access_key: ${{ secrets.CF_R2_TIP_AWS_KEY }} access_key: ${{ secrets.CF_R2_TIP_AWS_KEY }}
secreT_key: ${{ secrets.CF_R2_TIP_SECRET_KEY }} secreT_key: ${{ secrets.CF_R2_TIP_SECRET_KEY }}
# Load Build Number # Load Build Number
- name: Build Number - name: Build Number
run: | run: |
echo "GHOSTTY_BUILD=$(git rev-list --count head)" >> $GITHUB_ENV echo "GHOSTTY_BUILD=$(git rev-list --count head)" >> $GITHUB_ENV
# GhosttyKit is the framework that is built from Zig for our native # GhosttyKit is the framework that is built from Zig for our native
# Mac app to access. Build this in release mode. # Mac app to access. Build this in release mode.
- name: Build GhosttyKit - name: Build GhosttyKit
run: nix develop -c zig build -Dstatic=true -Doptimize=ReleaseFast run: nix develop -c zig build -Dstatic=true -Doptimize=ReleaseFast
# The native app is built with native XCode tooling. This also does # The native app is built with native XCode tooling. This also does
# codesigning. IMPORTANT: this must NOT run in a Nix environment. # codesigning. IMPORTANT: this must NOT run in a Nix environment.
# Nix breaks xcodebuild so this has to be run outside. # Nix breaks xcodebuild so this has to be run outside.
- name: Build Ghostty.app - name: Build Ghostty.app
run: cd macos && xcodebuild -configuration Release run: cd macos && xcodebuild -configuration Release
# We inject the "build number" as simply the number of commits since HEAD. # We inject the "build number" as simply the number of commits since HEAD.
# This will be a monotonically always increasing build number that we use. # This will be a monotonically always increasing build number that we use.
- name: Inject Build Number - name: Inject Build Number
run: | run: |
echo "Setting build to $GHOSTTY_BUILD" echo "Setting build to $GHOSTTY_BUILD"
/usr/libexec/PlistBuddy -c "Set :CFBundleVersion $GHOSTTY_BUILD" "macos/build/Release/Ghostty.app/Contents/Info.plist" /usr/libexec/PlistBuddy -c "Set :CFBundleVersion $GHOSTTY_BUILD" "macos/build/Release/Ghostty.app/Contents/Info.plist"
- name: Zip Unsigned App - name: Zip Unsigned App
run: nix develop -c sh -c 'cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal-unsigned.zip Ghostty.app' run: nix develop -c sh -c 'cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal-unsigned.zip Ghostty.app'
# Update Release # Update Release
- name: Release Unsigned - name: Release Unsigned
uses: softprops/action-gh-release@v1 uses: softprops/action-gh-release@v1
with: with:
name: "Ghostty Tip (\"Nightly\")" name: 'Ghostty Tip ("Nightly")'
prerelease: true prerelease: true
tag_name: tip tag_name: tip
target_commitish: ${{ github.sha }} target_commitish: ${{ github.sha }}
files: ghostty-macos-universal-unsigned.zip files: ghostty-macos-universal-unsigned.zip
token: ${{ secrets.GH_RELEASE_TOKEN }} token: ${{ secrets.GH_RELEASE_TOKEN }}
- name: Codesign app bundle - name: Codesign app bundle
env: env:
MACOS_CERTIFICATE: ${{ secrets.PROD_MACOS_CERTIFICATE }} MACOS_CERTIFICATE: ${{ secrets.PROD_MACOS_CERTIFICATE }}
MACOS_CERTIFICATE_PWD: ${{ secrets.PROD_MACOS_CERTIFICATE_PWD }} MACOS_CERTIFICATE_PWD: ${{ secrets.PROD_MACOS_CERTIFICATE_PWD }}
MACOS_CERTIFICATE_NAME: ${{ secrets.PROD_MACOS_CERTIFICATE_NAME }} MACOS_CERTIFICATE_NAME: ${{ secrets.PROD_MACOS_CERTIFICATE_NAME }}
MACOS_CI_KEYCHAIN_PWD: ${{ secrets.PROD_MACOS_CI_KEYCHAIN_PWD }} MACOS_CI_KEYCHAIN_PWD: ${{ secrets.PROD_MACOS_CI_KEYCHAIN_PWD }}
run: | run: |
# Turn our base64-encoded certificate back to a regular .p12 file # Turn our base64-encoded certificate back to a regular .p12 file
echo $MACOS_CERTIFICATE | base64 --decode > certificate.p12 echo $MACOS_CERTIFICATE | base64 --decode > certificate.p12
# We need to create a new keychain, otherwise using the certificate will prompt # We need to create a new keychain, otherwise using the certificate will prompt
# with a UI dialog asking for the certificate password, which we can't # with a UI dialog asking for the certificate password, which we can't
# use in a headless CI environment # use in a headless CI environment
security create-keychain -p "$MACOS_CI_KEYCHAIN_PWD" build.keychain security create-keychain -p "$MACOS_CI_KEYCHAIN_PWD" build.keychain
security default-keychain -s build.keychain security default-keychain -s build.keychain
security unlock-keychain -p "$MACOS_CI_KEYCHAIN_PWD" build.keychain security unlock-keychain -p "$MACOS_CI_KEYCHAIN_PWD" build.keychain
security import certificate.p12 -k build.keychain -P "$MACOS_CERTIFICATE_PWD" -T /usr/bin/codesign security import certificate.p12 -k build.keychain -P "$MACOS_CERTIFICATE_PWD" -T /usr/bin/codesign
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$MACOS_CI_KEYCHAIN_PWD" build.keychain security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$MACOS_CI_KEYCHAIN_PWD" build.keychain
# We finally codesign our app bundle, specifying the Hardened runtime option # We finally codesign our app bundle, specifying the Hardened runtime option
/usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime macos/build/Release/Ghostty.app -v /usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime macos/build/Release/Ghostty.app -v
- name: "Notarize app bundle" - name: "Notarize app bundle"
env: env:
PROD_MACOS_NOTARIZATION_APPLE_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_APPLE_ID }} PROD_MACOS_NOTARIZATION_APPLE_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_APPLE_ID }}
PROD_MACOS_NOTARIZATION_TEAM_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_TEAM_ID }} PROD_MACOS_NOTARIZATION_TEAM_ID: ${{ secrets.PROD_MACOS_NOTARIZATION_TEAM_ID }}
PROD_MACOS_NOTARIZATION_PWD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }} PROD_MACOS_NOTARIZATION_PWD: ${{ secrets.PROD_MACOS_NOTARIZATION_PWD }}
run: | run: |
# Store the notarization credentials so that we can prevent a UI password dialog # Store the notarization credentials so that we can prevent a UI password dialog
# from blocking the CI # from blocking the CI
echo "Create keychain profile" echo "Create keychain profile"
xcrun notarytool store-credentials "notarytool-profile" --apple-id "$PROD_MACOS_NOTARIZATION_APPLE_ID" --team-id "$PROD_MACOS_NOTARIZATION_TEAM_ID" --password "$PROD_MACOS_NOTARIZATION_PWD" xcrun notarytool store-credentials "notarytool-profile" --apple-id "$PROD_MACOS_NOTARIZATION_APPLE_ID" --team-id "$PROD_MACOS_NOTARIZATION_TEAM_ID" --password "$PROD_MACOS_NOTARIZATION_PWD"
# We can't notarize an app bundle directly, but we need to compress it as an archive. # We can't notarize an app bundle directly, but we need to compress it as an archive.
# Therefore, we create a zip file containing our app bundle, so that we can send it to the # Therefore, we create a zip file containing our app bundle, so that we can send it to the
# notarization service # notarization service
echo "Creating temp notarization archive" echo "Creating temp notarization archive"
ditto -c -k --keepParent "macos/build/Release/Ghostty.app" "notarization.zip" ditto -c -k --keepParent "macos/build/Release/Ghostty.app" "notarization.zip"
# Here we send the notarization request to the Apple's Notarization service, waiting for the result. # Here we send the notarization request to the Apple's Notarization service, waiting for the result.
# This typically takes a few seconds inside a CI environment, but it might take more depending on the App # This typically takes a few seconds inside a CI environment, but it might take more depending on the App
# characteristics. Visit the Notarization docs for more information and strategies on how to optimize it if # characteristics. Visit the Notarization docs for more information and strategies on how to optimize it if
# you're curious # you're curious
echo "Notarize app" echo "Notarize app"
xcrun notarytool submit "notarization.zip" --keychain-profile "notarytool-profile" --wait xcrun notarytool submit "notarization.zip" --keychain-profile "notarytool-profile" --wait
# Finally, we need to "attach the staple" to our executable, which will allow our app to be # Finally, we need to "attach the staple" to our executable, which will allow our app to be
# validated by macOS even when an internet connection is not available. # validated by macOS even when an internet connection is not available.
echo "Attach staple" echo "Attach staple"
xcrun stapler staple "macos/build/Release/Ghostty.app" xcrun stapler staple "macos/build/Release/Ghostty.app"
# Zip up the app # Zip up the app
- name: Zip App - name: Zip App
run: cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal.zip Ghostty.app run: cd macos/build/Release && zip -9 -r --symlinks ../../../ghostty-macos-universal.zip Ghostty.app
# Update Release # Update Release
- name: Release - name: Release
uses: softprops/action-gh-release@v1 uses: softprops/action-gh-release@v1
with: with:
name: "Ghostty Tip (\"Nightly\")" name: 'Ghostty Tip ("Nightly")'
prerelease: true prerelease: true
tag_name: tip tag_name: tip
target_commitish: ${{ github.sha }} target_commitish: ${{ github.sha }}
files: ghostty-macos-universal.zip files: ghostty-macos-universal.zip
token: ${{ secrets.GH_RELEASE_TOKEN }} token: ${{ secrets.GH_RELEASE_TOKEN }}
# Update Blob Storage # Update Blob Storage
- name: Upload to Blob Storage - name: Upload to Blob Storage
run: | run: |
s3cmd put ghostty-macos-universal.zip s3://ghostty-tip/${GHOSTTY_BUILD}/ghostty-macos-universal.zip s3cmd put ghostty-macos-universal.zip s3://ghostty-tip/${GHOSTTY_BUILD}/ghostty-macos-universal.zip

View File

@ -8,37 +8,36 @@ jobs:
os: [ubuntu-latest] os: [ubuntu-latest]
target: [ target: [
aarch64-macos, aarch64-macos,
x86_64-macos, x86_64-macos,
aarch64-linux-gnu, aarch64-linux-gnu,
x86_64-linux-gnu, x86_64-linux-gnu,
# No windows support currently.
# No windows support currently. # i386-windows,
# i386-windows, # x86_64-windows-gnu,
# x86_64-windows-gnu, ]
]
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
needs: test needs: test
env: env:
# Needed for macos SDK # Needed for macos SDK
AGREE: "true" AGREE: "true"
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v4 uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
fetch-depth: 0 fetch-depth: 0
# Install Nix and use that to run our tests so our environment matches exactly. # Install Nix and use that to run our tests so our environment matches exactly.
- uses: cachix/install-nix-action@v23 - uses: cachix/install-nix-action@v23
with: with:
nix_path: nixpkgs=channel:nixos-unstable nix_path: nixpkgs=channel:nixos-unstable
# Cross-compile the binary. We always use static building for this # Cross-compile the binary. We always use static building for this
# because its the only way to access the headers. # because its the only way to access the headers.
- name: Test Build - name: Test Build
run: nix develop -c zig build -Dstatic=true -Dapp-runtime=glfw -Dtarget=${{ matrix.target }} run: nix develop -c zig build -Dstatic=true -Dapp-runtime=glfw -Dtarget=${{ matrix.target }}
build-macos: build-macos:
runs-on: macos-12 runs-on: macos-12
@ -47,27 +46,27 @@ jobs:
# Needed for macos SDK # Needed for macos SDK
AGREE: "true" AGREE: "true"
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v4 uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
fetch-depth: 0 fetch-depth: 0
# Install Nix and use that to run our tests so our environment matches exactly. # Install Nix and use that to run our tests so our environment matches exactly.
- uses: cachix/install-nix-action@v23 - uses: cachix/install-nix-action@v23
with: with:
nix_path: nixpkgs=channel:nixos-unstable nix_path: nixpkgs=channel:nixos-unstable
# GhosttyKit is the framework that is built from Zig for our native # GhosttyKit is the framework that is built from Zig for our native
# Mac app to access. # Mac app to access.
- name: Build GhosttyKit - name: Build GhosttyKit
run: nix develop -c zig build -Dstatic=true run: nix develop -c zig build -Dstatic=true
# The native app is built with native XCode tooling. This also does # The native app is built with native XCode tooling. This also does
# codesigning. IMPORTANT: this must NOT run in a Nix environment. # codesigning. IMPORTANT: this must NOT run in a Nix environment.
# Nix breaks xcodebuild so this has to be run outside. # Nix breaks xcodebuild so this has to be run outside.
- name: Build Ghostty.app - name: Build Ghostty.app
run: cd macos && xcodebuild run: cd macos && xcodebuild
test: test:
strategy: strategy:
@ -75,25 +74,25 @@ jobs:
os: [ubuntu-latest] os: [ubuntu-latest]
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v4 uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
fetch-depth: 0 fetch-depth: 0
# Install Nix and use that to run our tests so our environment matches exactly. # Install Nix and use that to run our tests so our environment matches exactly.
- uses: cachix/install-nix-action@v23 - uses: cachix/install-nix-action@v23
with: with:
nix_path: nixpkgs=channel:nixos-unstable nix_path: nixpkgs=channel:nixos-unstable
- name: test - name: test
run: nix develop -c zig build -Dapp-runtime=none test run: nix develop -c zig build -Dapp-runtime=none test
- name: Test GTK Build - name: Test GTK Build
run: nix develop -c zig build -Dapp-runtime=gtk run: nix develop -c zig build -Dapp-runtime=gtk
- name: Test GLFW Build - name: Test GLFW Build
run: nix develop -c zig build -Dapp-runtime=glfw run: nix develop -c zig build -Dapp-runtime=glfw
- name: Test Dynamic Build - name: Test Dynamic Build
run: nix develop -c zig build -Dstatic=false run: nix develop -c zig build -Dstatic=false

View File

@ -3,7 +3,7 @@
# we want to keep _trying_ but its something with known issues. # we want to keep _trying_ but its something with known issues.
app-id: com.mitchellh.ghostty app-id: com.mitchellh.ghostty
runtime: org.gnome.Platform runtime: org.gnome.Platform
runtime-version: '43' runtime-version: "43"
sdk: org.gnome.Sdk sdk: org.gnome.Sdk
default-branch: tip default-branch: tip
command: ghostty command: ghostty

View File

@ -1,19 +1,19 @@
image: fedora:28 image: fedora:28
autotools-build: autotools-build:
script: script:
- dnf -y install dnf-plugins-core - dnf -y install dnf-plugins-core
- dnf -y groupinstall buildsys-build - dnf -y groupinstall buildsys-build
- dnf -y builddep pixman - dnf -y builddep pixman
- ./autogen.sh - ./autogen.sh
- make -sj4 check - make -sj4 check
meson-build: meson-build:
script: script:
- dnf -y install dnf-plugins-core - dnf -y install dnf-plugins-core
- dnf -y groupinstall buildsys-build - dnf -y groupinstall buildsys-build
- dnf -y builddep pixman - dnf -y builddep pixman
- dnf -y install ninja-build - dnf -y install ninja-build
- python3 -m pip install meson>=0.52.1 - python3 -m pip install meson>=0.52.1
- meson build - meson build
- ninja -C build test - ninja -C build test