superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gtk: better document what to do if gtk-xft-dpi <= 0

pull/5954/head
Jeffrey C. Ollie 2025-02-23 13:04:47 -06:00
parent bc2acdd060
commit ac7029256a
No known key found for this signature in database
GPG Key ID: 6F86035A6D97044E
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/apprt/gtk/Surface.zig
View File

@ -871,9 +871,12 @@ pub fn getContentScale(self: *const Surface) !apprt.ContentScale {
settings.as(gobject.Object).getProperty("gtk-xft-dpi", &value);
const gtk_xft_dpi = value.getInt();
// ensure that the scale is never negative
if (gtk_xft_dpi < 0) {
log.warn("gtk-xft-dpi setting was negative: {d:.3}", .{gtk_xft_dpi});
// Use a value of 1.0 for the XFT DPI scale if the setting is <= 0
// See:
// https://gitlab.gnome.org/GNOME/libadwaita/-/commit/a7738a4d269bfdf4d8d5429ca73ccdd9b2450421
// https://gitlab.gnome.org/GNOME/libadwaita/-/commit/9759d3fd81129608dd78116001928f2aed974ead
if (gtk_xft_dpi <= 0) {
log.warn("gtk-xft-dpi was not set, using default value", .{});
break :xft_scale 1.0;
}