superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clear selection when IME input starts

pull/4949/head
Bryan Lee 2025-01-12 01:48:48 +08:00
parent 2409d46600
commit af5e423ea5
No known key found for this signature in database
GPG Key ID: AA996124D88BE937
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/ghostty.h
View File

@ -748,6 +748,7 @@ void ghostty_surface_complete_clipboard_request(ghostty_surface_t,
bool); bool);
bool ghostty_surface_has_selection(ghostty_surface_t); bool ghostty_surface_has_selection(ghostty_surface_t);
uintptr_t ghostty_surface_selection(ghostty_surface_t, char*, uintptr_t); uintptr_t ghostty_surface_selection(ghostty_surface_t, char*, uintptr_t);
void ghostty_surface_clear_selection(ghostty_surface_t);
#ifdef __APPLE__ #ifdef __APPLE__
void ghostty_surface_set_display_id(ghostty_surface_t, uint32_t); void ghostty_surface_set_display_id(ghostty_surface_t, uint32_t);

5
macos/Sources/Ghostty/SurfaceView_AppKit.swift
View File

@ -1293,6 +1293,11 @@ extension Ghostty.SurfaceView: NSTextInputClient {
} }
func setMarkedText(_ string: Any, selectedRange: NSRange, replacementRange: NSRange) { func setMarkedText(_ string: Any, selectedRange: NSRange, replacementRange: NSRange) {
// Clear selection when IME input starts
if let surface = self.surface, ghostty_surface_has_selection(surface) {
ghostty_surface_clear_selection(surface)
}
switch string { switch string {
case let v as NSAttributedString: case let v as NSAttributedString:
self.markedText = NSMutableAttributedString(attributedString: v) self.markedText = NSMutableAttributedString(attributedString: v)

5
src/apprt/embedded.zig
View File

@ -1550,6 +1550,11 @@ pub const CAPI = struct {
return selection.len; return selection.len;
} }
/// Clear the current selection in the surface.
export fn ghostty_surface_clear_selection(surface: *Surface) void {
surface.core_surface.io.terminal.screen.clearSelection();
}
/// Tell the surface that it needs to schedule a render /// Tell the surface that it needs to schedule a render
export fn ghostty_surface_refresh(surface: *Surface) void { export fn ghostty_surface_refresh(surface: *Surface) void {
surface.refresh(); surface.refresh();