superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GTK: do not check for terminal area focus when setting window title (#6032) 

Fixes https://github.com/ghostty-org/ghostty/issues/5940
The mentioned problem occurs because when creating a new tab through the
tab overview we do not have focus on the terminal area widget, it does
not matter if we have a custom title set or not.
I think it is just safe to remove this check from the code. I've tested
the change and I don't really see a valid use case in which we would not
want to set the window title even if we don't have focus on the terminal
area.
pull/6047/head
Jeffrey C. Ollie 2025-03-01 12:10:13 -06:00 committed by GitHub
parent df62d45b36 a3cd7c6f02
commit b342909e10
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/apprt/gtk/Window.zig
View File

@ -667,6 +667,10 @@ pub fn focusCurrentTab(self: *Window) void {
const surface = tab.focus_child orelse return; const surface = tab.focus_child orelse return;
const gl_area = @as(*c.GtkWidget, @ptrCast(surface.gl_area)); const gl_area = @as(*c.GtkWidget, @ptrCast(surface.gl_area));
_ = c.gtk_widget_grab_focus(gl_area); _ = c.gtk_widget_grab_focus(gl_area);
if (surface.getTitle()) |title| {
self.setTitle(title);
}
} }
pub fn onConfigReloaded(self: *Window) void { pub fn onConfigReloaded(self: *Window) void {