superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

macOS 26: always reset titlebar tab constraints on frame change (#8610) 

Fixes #8595

Whenever the titlebar frame changes, we should set up our constraints
again to force it to re-render properly.
pull/8611/head
Mitchell Hashimoto 2025-09-12 20:40:53 -07:00 committed by GitHub
parent da7e3d1882 eaaf5aa8cf
commit bbf03cfa07
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
macos/Sources/Features/Terminal/Window Styles/TitlebarTabsTahoeTerminalWindow.swift
View File

@ -156,7 +156,7 @@ class TitlebarTabsTahoeTerminalWindow: TransparentTitlebarTerminalWindow, NSTool
accessoryView.needsLayout = true accessoryView.needsLayout = true
// Setup an observer for the NSTabBar frame. When system appearance changes or // Setup an observer for the NSTabBar frame. When system appearance changes or
// other events occur, the tab bar can temporarily become zero-sized. When this // other events occur, the tab bar can resize and clear our constraints. When this
// happens, we need to remove our custom constraints and re-apply them once the // happens, we need to remove our custom constraints and re-apply them once the
// tab bar has proper dimensions again to avoid constraint conflicts. // tab bar has proper dimensions again to avoid constraint conflicts.
tabBar.postsFrameChangedNotifications = true tabBar.postsFrameChangedNotifications = true
@ -167,9 +167,6 @@ class TitlebarTabsTahoeTerminalWindow: TransparentTitlebarTerminalWindow, NSTool
) { [weak self] _ in ) { [weak self] _ in
guard let self else { return } guard let self else { return }
// Check if either width or height is zero
guard tabBar.frame.size.width == 0 || tabBar.frame.size.height == 0 else { return }
// Remove the observer so we can call setup again. // Remove the observer so we can call setup again.
self.tabBarObserver = nil self.tabBarObserver = nil