superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2508 from qwerasd205/fix-map-capacity-off-by-1 

fix(PageList, Page): fix off-by-1 in map capacity checks
pull/2467/head
Mitchell Hashimoto 2024-10-28 15:48:12 -07:00 committed by GitHub
parent 2e4432a1e4 487f08b1dd
commit c413f2445d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/terminal/PageList.zig
View File

@ -896,7 +896,7 @@ const ReflowCursor = struct {
// If our page can't support an additional cell with // If our page can't support an additional cell with
// graphemes then we create a new page for this row. // graphemes then we create a new page for this row.
if (self.page.graphemeCount() >= self.page.graphemeCapacity() - 1) { if (self.page.graphemeCount() >= self.page.graphemeCapacity()) {
try self.moveLastRowToNewPage(list, cap); try self.moveLastRowToNewPage(list, cap);
} else { } else {
// Attempt to allocate the space that would be required for // Attempt to allocate the space that would be required for
@ -924,7 +924,7 @@ const ReflowCursor = struct {
// If our page can't support an additional cell with // If our page can't support an additional cell with
// a hyperlink ID then we create a new page for this row. // a hyperlink ID then we create a new page for this row.
if (self.page.hyperlinkCount() >= self.page.hyperlinkCapacity() - 1) { if (self.page.hyperlinkCount() >= self.page.hyperlinkCapacity()) {
try self.moveLastRowToNewPage(list, cap); try self.moveLastRowToNewPage(list, cap);
} }