superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf: streamline RefCountedSet lookup 

+ add branch hint to insert
pull/9645/head
Qwerasd 2025-11-18 15:42:29 -07:00
parent 81eda848cb
commit d14b4cf068
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/terminal/ref_counted_set.zig
View File

@ -515,14 +515,11 @@ pub fn RefCountedSet(
return null; return null;
} }
// We don't bother checking dead items.
if (item.meta.ref == 0) {
continue;
}
// If the item is a part of the same probe sequence, // If the item is a part of the same probe sequence,
// we check if it matches the value we're looking for. // we make sure it's not dead and then check to see
// if it matches the value we're looking for.
if (item.meta.psl == i and if (item.meta.psl == i and
item.meta.ref > 0 and
ctx.eql(value, item.value)) ctx.eql(value, item.value))
{ {
return id; return id;
@ -594,6 +591,11 @@ pub fn RefCountedSet(
// unless its ID is greater than the one we're // unless its ID is greater than the one we're
// given (i.e. prefer smaller IDs). // given (i.e. prefer smaller IDs).
if (item.meta.ref == 0) { if (item.meta.ref == 0) {
// Dead items aren't super common relative
// to other places to insert/swap the held
// item in to the set.
@branchHint(.unlikely);
if (comptime @hasDecl(Context, "deleted")) { if (comptime @hasDecl(Context, "deleted")) {
// Inform the context struct that we're // Inform the context struct that we're
// deleting the dead item's value for good. // deleting the dead item's value for good.