superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor(macos): do nothing if `background-opacity >= 1`

pull/9117/head
himura467 2025-10-10 12:56:20 +09:00 committed by Mitchell Hashimoto
parent 4c6d3f8ed2
commit ded3dd4cbc
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
macos/Sources/Features/Terminal/BaseTerminalController.swift
View File

@ -818,17 +818,14 @@ class BaseTerminalController: NSWindowController,
// MARK: Background Opacity // MARK: Background Opacity
/// Toggle the background opacity between transparent and opaque states. /// Toggle the background opacity between transparent and opaque states.
/// If the configured background-opacity is already opaque (>= 1), this resets /// Do nothing if the configured background-opacity is >= 1 (already opaque).
/// the override flag to false so that future config changes take effect. /// Subclasses should override this to add platform-specific checks and sync appearance.
/// Subclasses should override this to sync their appearance after toggling.
func toggleBackgroundOpacity() { func toggleBackgroundOpacity() {
// If config is already opaque, just ensure override is disabled // Do nothing if config is already fully opaque
if ghostty.config.backgroundOpacity >= 1 { guard ghostty.config.backgroundOpacity < 1 else { return }
isBackgroundOpaque = false
} else { // Toggle between transparent and opaque
// Otherwise toggle between transparent and opaque isBackgroundOpaque.toggle()
isBackgroundOpaque.toggle()
}
} }
// MARK: Fullscreen // MARK: Fullscreen