superrob1500
/
mirror-ghostty
mirror of https://github.com/ghostty-org/ghostty
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

macOS: check the resource the URL refers to. 

Fixes #12727. [`NSURL.hasDirectoryPath` doesn't do this](https://developer.apple.com/documentation/foundation/nsurl/hasdirectorypath).

We don't need to check this in NewTerminalIntent since AppIntent already appends `/` to the directory.
pull/12731/head
Lukas 2026-05-18 20:40:57 +02:00
parent 4b7bf0b20e
commit fdf84ef7ce
No known key found for this signature in database
GPG Key ID: 1944A0A77B561220
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
macos/Sources/Features/Services/ServiceProvider.swift
View File

@ -42,7 +42,13 @@ class ServiceProvider: NSObject {
// to their directories because that's the only thing we can open.
let directoryURLs = Set(
pathURLs.map { url -> URL in
url.hasDirectoryPath ? url : url.deletingLastPathComponent()
/// We check file system resources here because
/// NSURL doesn't append `/` when reading string contents from pasteboard
/// ```
/// NSURL(pasteboardPropertyList: "/System/Library".propertyList(), ofType: .fileURL)?.hasDirectoryPath
/// ```
let isDirectory = (try? url.resourceValues(forKeys: [.isDirectoryKey]))?.isDirectory ?? url.hasDirectoryPath
return isDirectory ? url : url.deletingLastPathComponent()
}
)