Commit Graph

1821 Commits (libvt-kitty)

Author SHA1 Message Date
Mitchell Hashimoto 8ae80892ba
macos: fix dock icon badge permission (#12133)
The previous version requested general notification permissions but
omitted the `.badge` option. Because the initial request was granted,
`settings.authorizationStatus` returns `.authorized`, leading the app to
believe it has full notification privileges when it actually lacks the
authority to update the dock icon badge.

Debug hint:
You can reset the notification settings by right-clicking on the app
name.
<img width="307" height="85" alt=""
src="https://github.com/user-attachments/assets/660cd332-eda6-45d6-8bfd-a6f9e28e21e8"
/>
2026-04-06 07:31:36 -07:00
fru1tworld 13f7d23145
macOS: force layout sync when frame size mismatches GeometryReader 2026-04-06 19:22:47 +09:00
Kay Leung e390937867 macos: fix badge permission
The previous version requested general notification permissions but omitted the `.badge` option. Because the initial request was granted, `settings.authorizationStatus` returns `.authorized`, leading the app to believe it has full notification privileges when it actually lacks the authority to update the dock icon badge.
2026-04-06 05:19:25 +08:00
Lukas 18f2702225
macOS: fix Find Next/Previous button in the menu bar is not working as expected 2026-04-02 20:31:31 +02:00
Lukas 9ec5672505
Revert "macOS: close search bar if needed when it loses focus (#11980)"
This reverts commit 20cfaae2e5, reversing
changes made to 3509ccf78e.
2026-04-01 19:21:42 +02:00
Lukas 702a2b43c3
macOS: fix upper cased letter is not correctly mapped to menu shortcut 2026-04-01 14:50:53 +02:00
Mitchell Hashimoto 292bf13d06
macOS: Make version in about dialog clickable (#12007)
- Fixes: https://github.com/ghostty-org/ghostty/issues/11964

Made a private enum type `VersionConfig` to reference whether the
release is a semver or tip, makes it easier for later in the view to
`switch` between cases.

I do think there could be a better place for this enum or we can get rid
of it, open to opinions. Right now version parsing is kind of duplicated
between `AboutView` and `UpdateModalView` so we can also extract to a
common helper if wanted.

Tested by manually setting `Marketing Version` in build settings to 

`1.3.1`
<img width="412" height="532" alt="Screenshot 2026-03-30 at 18 31 15"
src="https://github.com/user-attachments/assets/285bb94d-138b-4169-bb66-684eb04b6ca3"
/>

`332b2aefc`
<img width="412" height="532" alt="Screenshot 2026-03-30 at 18 32 48"
src="https://github.com/user-attachments/assets/fea30d39-bea7-4885-8221-1696e148f45e"
/>

### AI Disclosure
I used Sonnet 4.6 to understand where the version strings came from and
in what format, it read release yml files to see what's going on. Then
it proposed really bad code so I manually went in and cleaned up the
view.
2026-03-31 06:38:59 -07:00
Lukas 591dbd5112
macOS: fix incorrect delete symbol mapping 2026-03-31 10:27:12 +02:00
Louis Qian 010880a90a chore: make url computed property & rework enum signature 2026-03-30 20:15:01 -07:00
Louis Qian 183e2cef2f chore: clean up switch statement 2026-03-30 18:51:45 -07:00
Louis Qian 90d71dd2f6 chore: clean up comments 2026-03-30 18:49:17 -07:00
Louis Qian b29f261dc8 chore: clean up versionConfig to be init-able 2026-03-30 18:44:49 -07:00
Louis Qian ed6f0588a3 feat: make version clickable depending on type 2026-03-30 18:41:26 -07:00
Lukas a06350df9b
macOS: close search bar if needed when it loses focus
This adds features like:
1. Clicking outside of SearchBar works like typing `escape`
2. Typing `tab` while search bar is focused also works like typing `escape`
2026-03-30 18:29:44 +02:00
Mitchell Hashimoto d643792f36
macOS: add keyboard shortcut test (#11986)
This is the first step (also another step forward for completing #7879)
to fix various responder issues regarding keyboard shortcuts. I tried my
best to separate changes chunk by chunk; there will follow up pr based
on this to fix them.

This pr doesn't change any existing behaviours/flaws, but following
changes will be easier to review after this.

## AI Disclosure

Claude wrote most of the test cases
2026-03-30 09:20:35 -07:00
Mitchell Hashimoto 1672e891b9
macOS: remove redundant tab event overrides (#11984)
- Revert 5540f5f249, middle click comes
out of box with native tabbing, but we override it wrong previous.
- Reverts 894e8d91ba, I check it the
commit right before it and all the way back to
ffe4afe538, right mouse down on tab bar
works well without any issue
- Add back reverted handling in #11150


https://github.com/user-attachments/assets/8660368e-05ae-45b0-aa81-6196f3434daf
2026-03-30 09:19:33 -07:00
Lukas de8139bbc3
macOS: move MenuShortcutManager to a separate file 2026-03-30 16:10:06 +02:00
Lukas 1845dd26b6
macOS: extract menu shortcut syncing into MenuShortcutManager 2026-03-30 16:09:21 +02:00
Lukas 65cd31dc79
macOS: add NormalizedMenuShortcutKeyTests 2026-03-30 15:47:07 +02:00
Lukas 5c5f645b61
macOS: support reloading temporary config for testing 2026-03-30 15:47:07 +02:00
Lukas 51cd63871d
macos: passthrough right mouse down event to TabTitleEditor if needed (#11150) 2026-03-30 12:22:54 +02:00
Lukas 5de30c0dce
Revert "macOS: fix tab context menu opens on macOS 26 with titlebar tabs (#9831)"
This reverts commit 894e8d91ba, reversing
changes made to 4a173052fb.
2026-03-30 12:09:51 +02:00
Lukas 5c5029b0c4
Revert "macos: add support for middle-click tab close for `macos-titlebar-style = tabs` (#11963)"
This reverts commit 5540f5f249, reversing
changes made to cca4c788ad.
2026-03-30 12:08:49 +02:00
Lukas 013579cfcf
macOS: fix initial focus of command palette when building with Xcode 26.4
Tip works fine, but I've tried release and debug build with Xcode 26.4, it failed to focus as expected
2026-03-30 10:03:09 +02:00
Lukas 32920b6b2a
macOS: handle surface focus more gracefully
This will fix surface focus state is not consistent with first responder state when the search bar is open
2026-03-30 10:03:09 +02:00
Nicholas Ochoa 3f6683df02 macos: add support for middle-click tab close 2026-03-29 15:19:35 -07:00
Lukas ad0c5fbec3
macOS: fix regression caused by 3ee8ef4f65 2026-03-26 19:58:18 +01:00
Lukas 95ee878904
macOS: add test case for search bar focus change 2026-03-26 19:58:18 +01:00
Lukas d80d84862e
macOS: fix mouse not working correctly in CommandPaletteView (#11658) 2026-03-19 19:26:58 +01:00
Lukas ac3893d0b9
macOS: Add command palette tests 2026-03-19 19:26:57 +01:00
Lukas 50113ab678
macOS: add mouse state tests for #11276
It will fail on 4e24adf71 and success after #11276
2026-03-19 19:02:13 +01:00
Mitchell Hashimoto f3ac604fff
macos: select tab applescript command should not activate application (#11459)
Related to #11457
2026-03-13 08:53:53 -07:00
Mitchell Hashimoto 4c4e83784c
macos: new tab applescript command should not activate application
Related to #11457
2026-03-13 08:49:22 -07:00
Lukas 5c51603b0b
chore: make ci happy 2026-03-12 20:02:23 +01:00
Lukas 07bc888682
macOS: fix window position when dragging split into a new window 2026-03-12 19:54:41 +01:00
Lukas 3022aa05ea
macOS: add test cases for drag-split 2026-03-12 19:54:12 +01:00
Lukas d6d6fe4e58
macOS: update window cascading
Make it smaller and add comparisons between y values
2026-03-12 18:58:37 +01:00
Lukas 5e3866381b
macOS: fix window cascading for the second window 2026-03-12 18:32:04 +01:00
Lukas ea262cdd34
macOS: fix window cascading for 3rd+ window 2026-03-12 18:32:04 +01:00
Lukas 77c2acf843
macOS: add test case for window cascading without moving the window 2026-03-12 18:32:04 +01:00
Lukas 08107d342a
macOS: we don't need initialFrame anymore 2026-03-12 15:42:29 +01:00
Lukas 4f849a1512
macOS: fix window position for the very first window 2026-03-12 15:42:29 +01:00
Lukas c399812036
macOS: add test case for positioning the very first window 2026-03-12 15:42:28 +01:00
Lukas d6dfaf28fe
macOS: support injecting temporary defaults when testing 2026-03-12 13:16:55 +01:00
Mitchell Hashimoto ab269e2c79
config: add progress-style option (#11289)
Adds progress-style config to control OSC 9;4 progress bar visibility.
Defaults to true, set false to hide.

Fixes #11241

AI Disclosure: Claude Code (Opus 4.6) used for codebase exploration,
code review, and testing assistance. All code written and reviewed by
hand.
2026-03-11 20:46:59 -07:00
Mitchell Hashimoto 8093695055
macos: only run key equivalents for Ghostty-owned menu items
Fixes #11396

Track menu items populated from Ghostty keybind actions and only trigger
those from SurfaceView performKeyEquivalent. This avoids app-default
shortcuts such as Hide from pre-empting explicit keybinds.
2026-03-11 19:59:56 -07:00
Michal Olechowski 84d48d1c6a
config: add progress-style option
Add option to disable OSC 9;4 ConEmu progress bars via config.

Fixes #11241
2026-03-12 01:33:25 +01:00
Mitchell Hashimoto fe98f3884d
macos: only show split grab handle when the mouse is near it
Fixes #11379

For this pass, I made it a very simple "within 20%" (height-wise) of the
split handle. There is no horizontal component. I want to find the right
balance between always visible (today mostly) to only visible on direct
hover, because I think it'll be too hard to discover on that far right
side.
2026-03-11 10:48:09 -07:00
Mitchell Hashimoto 19e5053b28
macos: only show the grab handle in fullscreen if there are splits (#11381)
Fixes #11376
2026-03-11 10:08:25 -07:00
Mitchell Hashimoto 12bc1e7860
macos: only show the grab handle in fullscreen if there are splits
Fixes #11376
2026-03-11 10:02:09 -07:00