superrob1500
/
mirror-immich
mirror of https://github.com/immich-app/immich
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(web): fix timezone dropdown for timestamps lacking milliseconds (#23615) 

Fix timezone selector for timestamps without milliseconds
pull/23518/head^2
Sergey Katsubo 2025-11-05 17:03:55 +03:00 committed by GitHub
parent aa69d89b9f
commit 3cc9dd126c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/lib/modals/timezone-utils.ts
View File

@ -70,9 +70,14 @@ export function getModernOffsetForZoneAndDate(
function zoneOptionForDate(zone: string, date: string) { function zoneOptionForDate(zone: string, date: string) {
const { offsetMinutes, offsetFormat: zoneOffsetAtDate } = getModernOffsetForZoneAndDate(zone, date); const { offsetMinutes, offsetFormat: zoneOffsetAtDate } = getModernOffsetForZoneAndDate(zone, date);
// For validity, we still need to check if the exact date/time exists in the *original* timezone (for gaps/overlaps). // For validity, we still need to check if the exact date/time exists in the *original* timezone.
const dateForValidity = DateTime.fromISO(date, { zone }); // Use the fact that in DST gaps Luxon advances the missing time by an hour.
const valid = dateForValidity.isValid && date === dateForValidity.toFormat("yyyy-MM-dd'T'HH:mm:ss.SSS"); // Ignore milliseconds:
// - milliseconds are not relevant for TZ calculations
// - browsers strip insignificant .000 making string comparison with milliseconds more fragile.
const dateInTimezone = DateTime.fromISO(date, { zone });
const exists = date.replace(/\.\d+/, '') === dateInTimezone.toFormat("yyyy-MM-dd'T'HH:mm:ss");
const valid = dateInTimezone.isValid && exists;
return { return {
value: zone, value: zone,
offsetMinutes, offsetMinutes,