fix: version check

pull/28746/head
Daniel Dietzler 2026-06-01 16:34:24 +02:00
parent c8a1d0e400
commit fa7130f407
No known key found for this signature in database
GPG Key ID: A1C0B97CD8E18DFF
3 changed files with 12 additions and 3 deletions

View File

@ -1,5 +1,5 @@
import { AssetTypeEnum } from '@immich/sdk';
import { getAssetUrl } from '$lib/utils';
import { getAssetUrl, semverToName } from '$lib/utils';
import { assetFactory } from '@test-data/factories/asset-factory';
import { sharedLinkFactory } from '@test-data/factories/shared-link-factory';
@ -161,4 +161,13 @@ describe('utils', () => {
expect(url).toContain(asset.id);
});
});
describe('semverToName', () => {
it('should not append release candidate tag if prelease is not set', () => {
expect(semverToName({ major: 3, minor: 0, patch: 0, prerelease: null })).toEqual('v3.0.0');
});
it('should append release candidate if set', () => {
expect(semverToName({ major: 3, minor: 0, patch: 0, prerelease: 0 })).toEqual('v3.0.0-rc.0');
});
});
});

View File

@ -412,7 +412,7 @@ export function createDateFormatter(localeCode: string | undefined): DateFormatt
}
export const semverToName = ({ major, minor, patch, prerelease }: ServerVersionResponseDto) =>
`v${major}.${minor}.${patch}${prerelease ? `-rc.${prerelease}` : ''}`;
`v${major}.${minor}.${patch}${prerelease === null ? '' : `-rc.${prerelease}`}`;
export const withoutIcons = (actions: ActionItem[]): ActionItem[] =>
actions.map((action) => ({ ...action, icon: undefined }));

View File

@ -16,7 +16,7 @@
<div>
<div in:fade={{ duration: 500 }}>
<form autocomplete="off" onsubmit={(event) => event.preventDefault()}>
<div class="ms-4 mt-4">
<div class="ms-4 mt-4 flex flex-col gap-4">
<SettingSwitch
title={$t('admin.version_check_enabled_description')}
subtitle={$t('admin.version_check_implications', { values: { server: 'version.immich.cloud' } })}