superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

parport: remove non-zero check on count 

The check for count appears to be incorrect since a non-zero count
check occurs a couple of statements earlier. Currently the check is
always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
check is never tested and the if statement is dead-code. Fix this
by removing the check on count.

Note that this code is pre-git history, so I can't find a sha for
it.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Logically dead code")
Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
pull/78/merge
Colin Ian King 2021-07-30 11:07:10 +01:00 committed by Greg Kroah-Hartman
parent 8c61951b37
commit 0be883a0d7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/parport/ieee1284_ops.c
View File

@ -518,7 +518,7 @@ size_t parport_ieee1284_ecp_read_data (struct parport *port,
goto out; goto out;
/* Yield the port for a while. */ /* Yield the port for a while. */
if (count && dev->port->irq != PARPORT_IRQ_NONE) { if (dev->port->irq != PARPORT_IRQ_NONE) {
parport_release (dev); parport_release (dev);
schedule_timeout_interruptible(msecs_to_jiffies(40)); schedule_timeout_interruptible(msecs_to_jiffies(40));
parport_claim_or_block (dev); parport_claim_or_block (dev);