superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gfs2: Rename gfs2_{withdrawing_or_ => }withdrawn 

With delayed withdraws and the SDF_WITHDRAWING flag gone, we can now
rename gfs2_withdrawing_or_withdrawn() back to gfs2_withdrawn().

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
pull/1354/merge
Andreas Gruenbacher 2025-08-06 17:30:40 +02:00
parent 8daf6c2b3d
commit 1b7d498dca
15 changed files with 42 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/gfs2/aops.c
View File

@ -435,7 +435,7 @@ static int gfs2_read_folio(struct file *file, struct folio *folio)
error = mpage_read_folio(folio, gfs2_block_map); error = mpage_read_folio(folio, gfs2_block_map);
} }
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return -EIO; return -EIO;
return error; return error;

2
fs/gfs2/file.c
View File

@ -1446,7 +1446,7 @@ static int gfs2_lock(struct file *file, int cmd, struct file_lock *fl)
if (!(fl->c.flc_flags & FL_POSIX)) if (!(fl->c.flc_flags & FL_POSIX))
return -ENOLCK; return -ENOLCK;
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
if (lock_is_unlock(fl)) if (lock_is_unlock(fl))
locks_lock_file_wait(file, fl); locks_lock_file_wait(file, fl);
return -EIO; return -EIO;

8
fs/gfs2/glock.c
View File

@ -154,7 +154,7 @@ static bool glock_blocked_by_withdraw(struct gfs2_glock *gl)
{ {
struct gfs2_sbd *sdp = gl->gl_name.ln_sbd; struct gfs2_sbd *sdp = gl->gl_name.ln_sbd;
if (!gfs2_withdrawing_or_withdrawn(sdp)) if (!gfs2_withdrawn(sdp))
return false; return false;
if (gl->gl_ops->go_flags & GLOF_NONDISK) if (gl->gl_ops->go_flags & GLOF_NONDISK)
return false; return false;
@ -270,7 +270,7 @@ static void __gfs2_glock_put(struct gfs2_glock *gl)
GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders)); GLOCK_BUG_ON(gl, !list_empty(&gl->gl_holders));
if (mapping) { if (mapping) {
truncate_inode_pages_final(mapping); truncate_inode_pages_final(mapping);
if (!gfs2_withdrawing_or_withdrawn(sdp)) if (!gfs2_withdrawn(sdp))
GLOCK_BUG_ON(gl, !mapping_empty(mapping)); GLOCK_BUG_ON(gl, !mapping_empty(mapping));
} }
trace_gfs2_glock_put(gl); trace_gfs2_glock_put(gl);
@ -755,7 +755,7 @@ skip_inval:
* gfs2_gl_hash_clear calls clear_glock) and recovery is complete * gfs2_gl_hash_clear calls clear_glock) and recovery is complete
* then it's okay to tell dlm to unlock it. * then it's okay to tell dlm to unlock it.
*/ */
if (unlikely(sdp->sd_log_error) && !gfs2_withdrawing_or_withdrawn(sdp)) if (unlikely(sdp->sd_log_error) && !gfs2_withdrawn(sdp))
gfs2_withdraw(sdp); gfs2_withdraw(sdp);
if (glock_blocked_by_withdraw(gl) && if (glock_blocked_by_withdraw(gl) &&
(target != LM_ST_UNLOCKED || (target != LM_ST_UNLOCKED ||
@ -803,7 +803,7 @@ skip_inval:
*/ */
} else { } else {
fs_err(sdp, "lm_lock ret %d\n", ret); fs_err(sdp, "lm_lock ret %d\n", ret);
GLOCK_BUG_ON(gl, !gfs2_withdrawing_or_withdrawn(sdp)); GLOCK_BUG_ON(gl, !gfs2_withdrawn(sdp));
return; return;
} }
} }

2
fs/gfs2/glops.c
View File

@ -175,7 +175,7 @@ static int gfs2_rgrp_metasync(struct gfs2_glock *gl)
filemap_fdatawrite_range(metamapping, start, end); filemap_fdatawrite_range(metamapping, start, end);
error = filemap_fdatawait_range(metamapping, start, end); error = filemap_fdatawait_range(metamapping, start, end);
WARN_ON_ONCE(error && !gfs2_withdrawing_or_withdrawn(sdp)); WARN_ON_ONCE(error && !gfs2_withdrawn(sdp));
mapping_set_error(metamapping, error); mapping_set_error(metamapping, error);
if (error) if (error)
gfs2_io_error(sdp); gfs2_io_error(sdp);

8
fs/gfs2/lock_dlm.c
View File

@ -1195,7 +1195,7 @@ static void gdlm_recover_prep(void *arg)
struct gfs2_sbd *sdp = arg; struct gfs2_sbd *sdp = arg;
struct lm_lockstruct *ls = &sdp->sd_lockstruct; struct lm_lockstruct *ls = &sdp->sd_lockstruct;
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
fs_err(sdp, "recover_prep ignored due to withdraw.\n"); fs_err(sdp, "recover_prep ignored due to withdraw.\n");
return; return;
} }
@ -1221,7 +1221,7 @@ static void gdlm_recover_slot(void *arg, struct dlm_slot *slot)
struct lm_lockstruct *ls = &sdp->sd_lockstruct; struct lm_lockstruct *ls = &sdp->sd_lockstruct;
int jid = slot->slot - 1; int jid = slot->slot - 1;
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
fs_err(sdp, "recover_slot jid %d ignored due to withdraw.\n", fs_err(sdp, "recover_slot jid %d ignored due to withdraw.\n",
jid); jid);
return; return;
@ -1250,7 +1250,7 @@ static void gdlm_recover_done(void *arg, struct dlm_slot *slots, int num_slots,
struct gfs2_sbd *sdp = arg; struct gfs2_sbd *sdp = arg;
struct lm_lockstruct *ls = &sdp->sd_lockstruct; struct lm_lockstruct *ls = &sdp->sd_lockstruct;
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
fs_err(sdp, "recover_done ignored due to withdraw.\n"); fs_err(sdp, "recover_done ignored due to withdraw.\n");
return; return;
} }
@ -1281,7 +1281,7 @@ static void gdlm_recovery_result(struct gfs2_sbd *sdp, unsigned int jid,
{ {
struct lm_lockstruct *ls = &sdp->sd_lockstruct; struct lm_lockstruct *ls = &sdp->sd_lockstruct;
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
fs_err(sdp, "recovery_result jid %d ignored due to withdraw.\n", fs_err(sdp, "recovery_result jid %d ignored due to withdraw.\n",
jid); jid);
return; return;

22
fs/gfs2/log.c
View File

@ -118,7 +118,7 @@ __acquires(&sdp->sd_ail_lock)
} }
} }
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
gfs2_remove_from_ail(bd); gfs2_remove_from_ail(bd);
continue; continue;
} }
@ -834,7 +834,7 @@ void gfs2_write_log_header(struct gfs2_sbd *sdp, struct gfs2_jdesc *jd,
struct super_block *sb = sdp->sd_vfs; struct super_block *sb = sdp->sd_vfs;
u64 dblock; u64 dblock;
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return; return;
page = mempool_alloc(gfs2_page_pool, GFP_NOIO); page = mempool_alloc(gfs2_page_pool, GFP_NOIO);
@ -981,7 +981,7 @@ static void empty_ail1_list(struct gfs2_sbd *sdp)
gfs2_ail1_wait(sdp); gfs2_ail1_wait(sdp);
empty = gfs2_ail1_empty(sdp, 0); empty = gfs2_ail1_empty(sdp, 0);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
break; break;
} }
} }
@ -1044,7 +1044,7 @@ repeat:
* Do this check while holding the log_flush_lock to prevent new * Do this check while holding the log_flush_lock to prevent new
* buffers from being added to the ail via gfs2_pin() * buffers from being added to the ail via gfs2_pin()
*/ */
if (gfs2_withdrawing_or_withdrawn(sdp) || if (gfs2_withdrawn(sdp) ||
!test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags)) !test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags))
goto out; goto out;
@ -1094,14 +1094,14 @@ repeat:
goto out_withdraw; goto out_withdraw;
gfs2_ordered_write(sdp); gfs2_ordered_write(sdp);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
goto out_withdraw; goto out_withdraw;
lops_before_commit(sdp, tr); lops_before_commit(sdp, tr);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
goto out_withdraw; goto out_withdraw;
if (sdp->sd_jdesc) if (sdp->sd_jdesc)
gfs2_log_submit_bio(&sdp->sd_jdesc->jd_log_bio, REQ_OP_WRITE); gfs2_log_submit_bio(&sdp->sd_jdesc->jd_log_bio, REQ_OP_WRITE);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
goto out_withdraw; goto out_withdraw;
if (sdp->sd_log_head != sdp->sd_log_flush_head) { if (sdp->sd_log_head != sdp->sd_log_flush_head) {
@ -1109,7 +1109,7 @@ repeat:
} else if (sdp->sd_log_tail != sdp->sd_log_flush_tail && !sdp->sd_log_idle) { } else if (sdp->sd_log_tail != sdp->sd_log_flush_tail && !sdp->sd_log_idle) {
log_write_header(sdp, flags); log_write_header(sdp, flags);
} }
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
goto out_withdraw; goto out_withdraw;
lops_after_commit(sdp, tr); lops_after_commit(sdp, tr);
@ -1127,7 +1127,7 @@ repeat:
if (!(flags & GFS2_LOG_HEAD_FLUSH_NORMAL)) { if (!(flags & GFS2_LOG_HEAD_FLUSH_NORMAL)) {
if (!sdp->sd_log_idle) { if (!sdp->sd_log_idle) {
empty_ail1_list(sdp); empty_ail1_list(sdp);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
goto out_withdraw; goto out_withdraw;
log_write_header(sdp, flags); log_write_header(sdp, flags);
} }
@ -1296,7 +1296,7 @@ int gfs2_logd(void *data)
set_freezable(); set_freezable();
while (!kthread_should_stop()) { while (!kthread_should_stop()) {
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
break; break;
/* Check for errors writing to the journal */ /* Check for errors writing to the journal */
@ -1333,7 +1333,7 @@ int gfs2_logd(void *data)
gfs2_ail_flush_reqd(sdp) || gfs2_ail_flush_reqd(sdp) ||
gfs2_jrnl_flush_reqd(sdp) || gfs2_jrnl_flush_reqd(sdp) ||
sdp->sd_log_error || sdp->sd_log_error ||
gfs2_withdrawing_or_withdrawn(sdp) || gfs2_withdrawn(sdp) ||
kthread_should_stop(), kthread_should_stop(),
t); t);
} }

6
fs/gfs2/meta_io.c
View File

@ -263,7 +263,7 @@ int gfs2_meta_read(struct gfs2_glock *gl, u64 blkno, int flags,
struct buffer_head *bh, *bhs[2]; struct buffer_head *bh, *bhs[2];
int num = 0; int num = 0;
if (gfs2_withdrawing_or_withdrawn(sdp) && if (gfs2_withdrawn(sdp) &&
!gfs2_withdraw_in_prog(sdp)) { !gfs2_withdraw_in_prog(sdp)) {
*bhp = NULL; *bhp = NULL;
return -EIO; return -EIO;
@ -322,7 +322,7 @@ int gfs2_meta_read(struct gfs2_glock *gl, u64 blkno, int flags,
int gfs2_meta_wait(struct gfs2_sbd *sdp, struct buffer_head *bh) int gfs2_meta_wait(struct gfs2_sbd *sdp, struct buffer_head *bh)
{ {
if (gfs2_withdrawing_or_withdrawn(sdp) && if (gfs2_withdrawn(sdp) &&
!gfs2_withdraw_in_prog(sdp)) !gfs2_withdraw_in_prog(sdp))
return -EIO; return -EIO;
@ -334,7 +334,7 @@ int gfs2_meta_wait(struct gfs2_sbd *sdp, struct buffer_head *bh)
gfs2_io_error_bh_wd(sdp, bh); gfs2_io_error_bh_wd(sdp, bh);
return -EIO; return -EIO;
} }
if (gfs2_withdrawing_or_withdrawn(sdp) && if (gfs2_withdrawn(sdp) &&
!gfs2_withdraw_in_prog(sdp)) !gfs2_withdraw_in_prog(sdp))
return -EIO; return -EIO;

2
fs/gfs2/ops_fstype.c
View File

@ -1040,7 +1040,7 @@ hostdata_error:
void gfs2_lm_unmount(struct gfs2_sbd *sdp) void gfs2_lm_unmount(struct gfs2_sbd *sdp)
{ {
const struct lm_lockops *lm = sdp->sd_lockstruct.ls_ops; const struct lm_lockops *lm = sdp->sd_lockstruct.ls_ops;
if (!gfs2_withdrawing_or_withdrawn(sdp) && lm->lm_unmount) if (!gfs2_withdrawn(sdp) && lm->lm_unmount)
lm->lm_unmount(sdp, true); lm->lm_unmount(sdp, true);
} }

8
fs/gfs2/quota.c
View File

@ -125,7 +125,7 @@ static void gfs2_qd_dispose(struct gfs2_quota_data *qd)
hlist_bl_del_rcu(&qd->qd_hlist); hlist_bl_del_rcu(&qd->qd_hlist);
spin_unlock_bucket(qd->qd_hash); spin_unlock_bucket(qd->qd_hash);
if (!gfs2_withdrawing_or_withdrawn(sdp)) { if (!gfs2_withdrawn(sdp)) {
gfs2_assert_warn(sdp, !qd->qd_change); gfs2_assert_warn(sdp, !qd->qd_change);
gfs2_assert_warn(sdp, !qd->qd_slot_ref); gfs2_assert_warn(sdp, !qd->qd_slot_ref);
gfs2_assert_warn(sdp, !qd->qd_bh_count); gfs2_assert_warn(sdp, !qd->qd_bh_count);
@ -1551,7 +1551,7 @@ static void quotad_error(struct gfs2_sbd *sdp, const char *msg, int error)
{ {
if (error == 0 || error == -EROFS) if (error == 0 || error == -EROFS)
return; return;
if (!gfs2_withdrawing_or_withdrawn(sdp)) { if (!gfs2_withdrawn(sdp)) {
if (!cmpxchg(&sdp->sd_log_error, 0, error)) if (!cmpxchg(&sdp->sd_log_error, 0, error))
fs_err(sdp, "gfs2_quotad: %s error %d\n", msg, error); fs_err(sdp, "gfs2_quotad: %s error %d\n", msg, error);
wake_up(&sdp->sd_logd_waitq); wake_up(&sdp->sd_logd_waitq);
@ -1583,7 +1583,7 @@ int gfs2_quotad(void *data)
while (!kthread_should_stop()) { while (!kthread_should_stop()) {
unsigned long t; unsigned long t;
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
break; break;
now = jiffies; now = jiffies;
@ -1614,7 +1614,7 @@ int gfs2_quotad(void *data)
t = min(statfs_deadline - now, quotad_deadline - now); t = min(statfs_deadline - now, quotad_deadline - now);
wait_event_freezable_timeout(sdp->sd_quota_wait, wait_event_freezable_timeout(sdp->sd_quota_wait,
sdp->sd_statfs_force_sync || sdp->sd_statfs_force_sync ||
gfs2_withdrawing_or_withdrawn(sdp) || gfs2_withdrawn(sdp) ||
kthread_should_stop(), kthread_should_stop(),
t); t);

2
fs/gfs2/recovery.c
View File

@ -408,7 +408,7 @@ void gfs2_recover_func(struct work_struct *work)
int error = 0; int error = 0;
int jlocked = 0; int jlocked = 0;
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
fs_err(sdp, "jid=%u: Recovery not attempted due to withdraw.\n", fs_err(sdp, "jid=%u: Recovery not attempted due to withdraw.\n",
jd->jd_jid); jd->jd_jid);
goto fail; goto fail;

10
fs/gfs2/super.c
View File

@ -137,7 +137,7 @@ int gfs2_make_fs_rw(struct gfs2_sbd *sdp)
int error; int error;
j_gl->gl_ops->go_inval(j_gl, DIO_METADATA); j_gl->gl_ops->go_inval(j_gl, DIO_METADATA);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return -EIO; return -EIO;
if (sdp->sd_log_sequence == 0) { if (sdp->sd_log_sequence == 0) {
@ -147,7 +147,7 @@ int gfs2_make_fs_rw(struct gfs2_sbd *sdp)
} }
error = gfs2_quota_init(sdp); error = gfs2_quota_init(sdp);
if (!error && gfs2_withdrawing_or_withdrawn(sdp)) if (!error && gfs2_withdrawn(sdp))
error = -EIO; error = -EIO;
if (!error) if (!error)
set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags); set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags);
@ -491,7 +491,7 @@ static void gfs2_dirty_inode(struct inode *inode, int flags)
if (unlikely(!ip->i_gl)) if (unlikely(!ip->i_gl))
return; return;
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return; return;
if (!gfs2_glock_is_locked_by_me(ip->i_gl)) { if (!gfs2_glock_is_locked_by_me(ip->i_gl)) {
ret = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh); ret = gfs2_glock_nq_init(ip->i_gl, LM_ST_EXCLUSIVE, 0, &gh);
@ -597,7 +597,7 @@ restart:
if (!sb_rdonly(sb)) if (!sb_rdonly(sb))
gfs2_make_fs_ro(sdp); gfs2_make_fs_ro(sdp);
else { else {
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
gfs2_destroy_threads(sdp); gfs2_destroy_threads(sdp);
gfs2_quota_cleanup(sdp); gfs2_quota_cleanup(sdp);
@ -776,7 +776,7 @@ static int gfs2_freeze_fs(struct super_block *sb)
if (test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags)) { if (test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags)) {
gfs2_log_flush(sdp, NULL, GFS2_LOG_HEAD_FLUSH_FREEZE | gfs2_log_flush(sdp, NULL, GFS2_LOG_HEAD_FLUSH_FREEZE |
GFS2_LFC_FREEZE_GO_SYNC); GFS2_LFC_FREEZE_GO_SYNC);
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return -EIO; return -EIO;
} }
return 0; return 0;

2
fs/gfs2/sys.c
View File

@ -191,7 +191,7 @@ static ssize_t freeze_store(struct gfs2_sbd *sdp, const char *buf, size_t len)
static ssize_t withdraw_show(struct gfs2_sbd *sdp, char *buf) static ssize_t withdraw_show(struct gfs2_sbd *sdp, char *buf)
{ {
unsigned int b = gfs2_withdrawing_or_withdrawn(sdp); unsigned int b = gfs2_withdrawn(sdp);
return sysfs_emit(buf, "%u\n", b); return sysfs_emit(buf, "%u\n", b);
} }

2
fs/gfs2/trans.c
View File

@ -289,7 +289,7 @@ void gfs2_trans_add_meta(struct gfs2_glock *gl, struct buffer_head *bh)
(unsigned long long)bd->bd_bh->b_blocknr); (unsigned long long)bd->bd_bh->b_blocknr);
BUG(); BUG();
} }
if (gfs2_withdrawing_or_withdrawn(sdp)) { if (gfs2_withdrawn(sdp)) {
fs_info(sdp, "GFS2:adding buf while withdrawn! 0x%llx\n", fs_info(sdp, "GFS2:adding buf while withdrawn! 0x%llx\n",
(unsigned long long)bd->bd_bh->b_blocknr); (unsigned long long)bd->bd_bh->b_blocknr);
goto out_unlock; goto out_unlock;

4
fs/gfs2/util.c
View File

@ -366,7 +366,7 @@ void gfs2_withdraw(struct gfs2_sbd *sdp)
void gfs2_assert_withdraw_i(struct gfs2_sbd *sdp, char *assertion, void gfs2_assert_withdraw_i(struct gfs2_sbd *sdp, char *assertion,
const char *function, char *file, unsigned int line) const char *function, char *file, unsigned int line)
{ {
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return; return;
fs_err(sdp, fs_err(sdp,
@ -524,7 +524,7 @@ void gfs2_io_error_bh_i(struct gfs2_sbd *sdp, struct buffer_head *bh,
const char *function, char *file, unsigned int line, const char *function, char *file, unsigned int line,
bool withdraw) bool withdraw)
{ {
if (gfs2_withdrawing_or_withdrawn(sdp)) if (gfs2_withdrawn(sdp))
return; return;
fs_err(sdp, "fatal: I/O error - " fs_err(sdp, "fatal: I/O error - "

5
fs/gfs2/util.h
View File

@ -183,11 +183,10 @@ static inline unsigned int gfs2_tune_get_i(struct gfs2_tune *gt,
} }
/** /**
* gfs2_withdrawing_or_withdrawn - test whether the file system is withdrawing * gfs2_withdrawn - test whether the file system is withdrawn
* or withdrawn
* @sdp: the superblock * @sdp: the superblock
*/ */
static inline bool gfs2_withdrawing_or_withdrawn(struct gfs2_sbd *sdp) static inline bool gfs2_withdrawn(struct gfs2_sbd *sdp)
{ {
return unlikely(test_bit(SDF_WITHDRAWN, &sdp->sd_flags)); return unlikely(test_bit(SDF_WITHDRAWN, &sdp->sd_flags));
} }