superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ALSA: firewire-motu: add bounds check in put_user loop for DSP events 

In the DSP event handling code, a put_user() loop copies event data.
When the user buffer size is not aligned to 4 bytes, it could overwrite
beyond the buffer boundary.

Fix by adding a bounds check before put_user().

Suggested-by: Takashi Iwai <tiwai@suse.de>
Fixes: 634ec0b290 ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
Signed-off-by: Junrui Luo <moonafterrain@outlook.com>
Link: https://patch.msgid.link/SYBPR01MB788112C72AF8A1C8C448B4B8AFA3A@SYBPR01MB7881.ausprd01.prod.outlook.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
master
Junrui Luo 2025-12-09 13:16:41 +08:00 committed by Takashi Iwai
parent 9a97857db0
commit 298e753880
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/firewire/motu/motu-hwdep.c
View File

@ -75,7 +75,7 @@ static long hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count,
while (consumed < count && while (consumed < count &&
snd_motu_register_dsp_message_parser_copy_event(motu, &ev)) { snd_motu_register_dsp_message_parser_copy_event(motu, &ev)) {
ptr = (u32 __user *)(buf + consumed); ptr = (u32 __user *)(buf + consumed);
if (put_user(ev, ptr)) if (consumed + sizeof(ev) > count || put_user(ev, ptr))
return -EFAULT; return -EFAULT;
consumed += sizeof(ev); consumed += sizeof(ev);
} }