superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

orangefs: Remove unused type in macro fill_default_sys_attrs 

Remove the unused type parameter from the macro definition and all its
callers, making the interface consistent with its actual usage.

Fixes: 69a23de2f3 ("orangefs: clean up fill_default_sys_attrs")
Signed-off-by: Zhen Ni <zhen.ni@easystack.cn>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
pull/1354/merge
Zhen Ni 2025-09-01 10:58:18 +08:00 committed by Mike Marshall
parent f83ec76bf2
commit 3dffadfa99
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/orangefs/namei.c
View File

@ -38,8 +38,7 @@ static int orangefs_create(struct mnt_idmap *idmap,
new_op->upcall.req.create.parent_refn = parent->refn; new_op->upcall.req.create.parent_refn = parent->refn;
fill_default_sys_attrs(new_op->upcall.req.create.attributes, fill_default_sys_attrs(new_op->upcall.req.create.attributes, mode);
ORANGEFS_TYPE_METAFILE, mode);
strscpy(new_op->upcall.req.create.d_name, dentry->d_name.name); strscpy(new_op->upcall.req.create.d_name, dentry->d_name.name);
@ -240,9 +239,7 @@ static int orangefs_symlink(struct mnt_idmap *idmap,
new_op->upcall.req.sym.parent_refn = parent->refn; new_op->upcall.req.sym.parent_refn = parent->refn;
fill_default_sys_attrs(new_op->upcall.req.sym.attributes, fill_default_sys_attrs(new_op->upcall.req.sym.attributes, mode);
ORANGEFS_TYPE_SYMLINK,
mode);
strscpy(new_op->upcall.req.sym.entry_name, dentry->d_name.name); strscpy(new_op->upcall.req.sym.entry_name, dentry->d_name.name);
strscpy(new_op->upcall.req.sym.target, symname); strscpy(new_op->upcall.req.sym.target, symname);
@ -316,8 +313,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
new_op->upcall.req.mkdir.parent_refn = parent->refn; new_op->upcall.req.mkdir.parent_refn = parent->refn;
fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes, fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes, mode);
ORANGEFS_TYPE_DIRECTORY, mode);
strscpy(new_op->upcall.req.mkdir.d_name, dentry->d_name.name); strscpy(new_op->upcall.req.mkdir.d_name, dentry->d_name.name);

2
fs/orangefs/orangefs-kernel.h
View File

@ -462,7 +462,7 @@ int service_operation(struct orangefs_kernel_op_s *op,
((ORANGEFS_SB(inode->i_sb)->flags & ORANGEFS_OPT_INTR) ? \ ((ORANGEFS_SB(inode->i_sb)->flags & ORANGEFS_OPT_INTR) ? \
ORANGEFS_OP_INTERRUPTIBLE : 0) ORANGEFS_OP_INTERRUPTIBLE : 0)
#define fill_default_sys_attrs(sys_attr, type, mode) \ #define fill_default_sys_attrs(sys_attr, mode) \
do { \ do { \
sys_attr.owner = from_kuid(&init_user_ns, current_fsuid()); \ sys_attr.owner = from_kuid(&init_user_ns, current_fsuid()); \
sys_attr.group = from_kgid(&init_user_ns, current_fsgid()); \ sys_attr.group = from_kgid(&init_user_ns, current_fsgid()); \