superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net/sched: cbs: Fix error path of cbs_module_init 

If register_qdisc fails, we should unregister
netdevice notifier.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e0a7683d30 ("net/sched: cbs: fix port_rate miscalculation")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
pull/697/head
YueHaibing 2019-06-21 21:44:37 +08:00 committed by David S. Miller
parent c492d4c74d
commit 45d5cb137c
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
net/sched/sch_cbs.c
View File

@ -549,12 +549,17 @@ static struct notifier_block cbs_device_notifier = {
static int __init cbs_module_init(void) static int __init cbs_module_init(void)
{ {
int err = register_netdevice_notifier(&cbs_device_notifier); int err;
err = register_netdevice_notifier(&cbs_device_notifier);
if (err) if (err)
return err; return err;
return register_qdisc(&cbs_qdisc_ops); err = register_qdisc(&cbs_qdisc_ops);
if (err)
unregister_netdevice_notifier(&cbs_device_notifier);
return err;
} }
static void __exit cbs_module_exit(void) static void __exit cbs_module_exit(void)