crypto: bcm - set memory to zero only once
Use kmalloc_array() instead of kcalloc() because sg_init_table() already sets the memory to zero. This avoids zeroing the memory twice. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>pull/1188/head
parent
0926d8ee08
commit
4f95a6d274
|
|
@ -141,8 +141,8 @@ spu_skcipher_rx_sg_create(struct brcm_message *mssg,
|
||||||
struct iproc_ctx_s *ctx = rctx->ctx;
|
struct iproc_ctx_s *ctx = rctx->ctx;
|
||||||
u32 datalen; /* Number of bytes of response data expected */
|
u32 datalen; /* Number of bytes of response data expected */
|
||||||
|
|
||||||
mssg->spu.dst = kcalloc(rx_frag_num, sizeof(struct scatterlist),
|
mssg->spu.dst = kmalloc_array(rx_frag_num, sizeof(struct scatterlist),
|
||||||
rctx->gfp);
|
rctx->gfp);
|
||||||
if (!mssg->spu.dst)
|
if (!mssg->spu.dst)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
@ -205,8 +205,8 @@ spu_skcipher_tx_sg_create(struct brcm_message *mssg,
|
||||||
u32 datalen; /* Number of bytes of response data expected */
|
u32 datalen; /* Number of bytes of response data expected */
|
||||||
u32 stat_len;
|
u32 stat_len;
|
||||||
|
|
||||||
mssg->spu.src = kcalloc(tx_frag_num, sizeof(struct scatterlist),
|
mssg->spu.src = kmalloc_array(tx_frag_num, sizeof(struct scatterlist),
|
||||||
rctx->gfp);
|
rctx->gfp);
|
||||||
if (unlikely(!mssg->spu.src))
|
if (unlikely(!mssg->spu.src))
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
@ -532,8 +532,8 @@ spu_ahash_rx_sg_create(struct brcm_message *mssg,
|
||||||
struct scatterlist *sg; /* used to build sgs in mbox message */
|
struct scatterlist *sg; /* used to build sgs in mbox message */
|
||||||
struct iproc_ctx_s *ctx = rctx->ctx;
|
struct iproc_ctx_s *ctx = rctx->ctx;
|
||||||
|
|
||||||
mssg->spu.dst = kcalloc(rx_frag_num, sizeof(struct scatterlist),
|
mssg->spu.dst = kmalloc_array(rx_frag_num, sizeof(struct scatterlist),
|
||||||
rctx->gfp);
|
rctx->gfp);
|
||||||
if (!mssg->spu.dst)
|
if (!mssg->spu.dst)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
@ -587,8 +587,8 @@ spu_ahash_tx_sg_create(struct brcm_message *mssg,
|
||||||
u32 datalen; /* Number of bytes of response data expected */
|
u32 datalen; /* Number of bytes of response data expected */
|
||||||
u32 stat_len;
|
u32 stat_len;
|
||||||
|
|
||||||
mssg->spu.src = kcalloc(tx_frag_num, sizeof(struct scatterlist),
|
mssg->spu.src = kmalloc_array(tx_frag_num, sizeof(struct scatterlist),
|
||||||
rctx->gfp);
|
rctx->gfp);
|
||||||
if (!mssg->spu.src)
|
if (!mssg->spu.src)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
@ -1077,8 +1077,8 @@ static int spu_aead_rx_sg_create(struct brcm_message *mssg,
|
||||||
/* have to catch gcm pad in separate buffer */
|
/* have to catch gcm pad in separate buffer */
|
||||||
rx_frag_num++;
|
rx_frag_num++;
|
||||||
|
|
||||||
mssg->spu.dst = kcalloc(rx_frag_num, sizeof(struct scatterlist),
|
mssg->spu.dst = kmalloc_array(rx_frag_num, sizeof(struct scatterlist),
|
||||||
rctx->gfp);
|
rctx->gfp);
|
||||||
if (!mssg->spu.dst)
|
if (!mssg->spu.dst)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
@ -1179,8 +1179,8 @@ static int spu_aead_tx_sg_create(struct brcm_message *mssg,
|
||||||
u32 assoc_offset = 0;
|
u32 assoc_offset = 0;
|
||||||
u32 stat_len;
|
u32 stat_len;
|
||||||
|
|
||||||
mssg->spu.src = kcalloc(tx_frag_num, sizeof(struct scatterlist),
|
mssg->spu.src = kmalloc_array(tx_frag_num, sizeof(struct scatterlist),
|
||||||
rctx->gfp);
|
rctx->gfp);
|
||||||
if (!mssg->spu.src)
|
if (!mssg->spu.src)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue