superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: xpcs: remove xpcs_config_eee() from global scope 

Make xpcs_config_eee() private to the XPCS driver, called only from
the phylink pcs_disable_eee() and pcs_enable_eee() methods.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1thRQT-003w7O-Ec@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
pull/1188/head
Russell King (Oracle) 2025-02-10 10:54:05 +00:00 committed by Jakub Kicinski
parent dba7441b39
commit 55faeb8996
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/pcs/pcs-xpcs.c
View File

@ -602,8 +602,8 @@ static void xpcs_get_interfaces(struct dw_xpcs *xpcs, unsigned long *interfaces)
__set_bit(compat->interface, interfaces); __set_bit(compat->interface, interfaces);
} }
static int __xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, static int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,
int enable) int enable)
{ {
u16 mask, val; u16 mask, val;
int ret; int ret;
@ -632,12 +632,6 @@ static int __xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,
enable ? DW_VR_MII_EEE_TRN_LPI : 0); enable ? DW_VR_MII_EEE_TRN_LPI : 0);
} }
int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, int enable)
{
return 0;
}
EXPORT_SYMBOL_GPL(xpcs_config_eee);
static void xpcs_pre_config(struct phylink_pcs *pcs, phy_interface_t interface) static void xpcs_pre_config(struct phylink_pcs *pcs, phy_interface_t interface)
{ {
struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs); struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs);
@ -1203,14 +1197,14 @@ static void xpcs_disable_eee(struct phylink_pcs *pcs)
{ {
struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs); struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs);
__xpcs_config_eee(xpcs, 0, false); xpcs_config_eee(xpcs, 0, false);
} }
static void xpcs_enable_eee(struct phylink_pcs *pcs) static void xpcs_enable_eee(struct phylink_pcs *pcs)
{ {
struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs); struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs);
__xpcs_config_eee(xpcs, xpcs->eee_mult_fact, true); xpcs_config_eee(xpcs, xpcs->eee_mult_fact, true);
} }
/** /**

2
include/linux/pcs/pcs-xpcs.h
View File

@ -50,8 +50,6 @@ struct dw_xpcs;
struct phylink_pcs *xpcs_to_phylink_pcs(struct dw_xpcs *xpcs); struct phylink_pcs *xpcs_to_phylink_pcs(struct dw_xpcs *xpcs);
int xpcs_get_an_mode(struct dw_xpcs *xpcs, phy_interface_t interface); int xpcs_get_an_mode(struct dw_xpcs *xpcs, phy_interface_t interface);
int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,
int enable);
void xpcs_config_eee_mult_fact(struct dw_xpcs *xpcs, u8 mult_fact); void xpcs_config_eee_mult_fact(struct dw_xpcs *xpcs, u8 mult_fact);
struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr); struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr);
struct dw_xpcs *xpcs_create_fwnode(struct fwnode_handle *fwnode); struct dw_xpcs *xpcs_create_fwnode(struct fwnode_handle *fwnode);