superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iio: light: tcs3414: Use iio_push_to_buffers_with_ts() to allow source size runtime check 

Use iio_push_to_buffers_with_ts() to allow source size runtime check.

Also move the structure used as the source to the stack as it is only 16
bytes and not the target of an DMA or similar.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://patch.msgid.link/20250802164436.515988-13-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
pull/1354/merge
Jonathan Cameron 2025-08-02 17:44:32 +01:00
parent cb8453db63
commit 7cacdd9380
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/iio/light/tcs3414.c
View File

@ -53,11 +53,6 @@ struct tcs3414_data {
u8 control;
u8 gain;
u8 timing;
/* Ensure timestamp is naturally aligned */
struct {
u16 chans[4];
aligned_s64 timestamp;
} scan;
};
#define TCS3414_CHANNEL(_color, _si, _addr) { \
@ -204,6 +199,12 @@ static irqreturn_t tcs3414_trigger_handler(int irq, void *p)
struct iio_dev *indio_dev = pf->indio_dev;
struct tcs3414_data *data = iio_priv(indio_dev);
int i, j = 0;
/* Ensure timestamp is naturally aligned */
struct {
u16 chans[4];
aligned_s64 timestamp;
} scan = { };
iio_for_each_active_channel(indio_dev, i) {
int ret = i2c_smbus_read_word_data(data->client,
@ -211,10 +212,10 @@ static irqreturn_t tcs3414_trigger_handler(int irq, void *p)
if (ret < 0)
goto done;
data->scan.chans[j++] = ret;
scan.chans[j++] = ret;
}
iio_push_to_buffers_with_timestamp(indio_dev, &data->scan,
iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan),
iio_get_time_ns(indio_dev));
done: