rust: allow globally `clippy::incompatible_msrv`
`clippy::incompatible_msrv` is not buying us much, and we discussed allowing it several times in the past. For instance, there was recently another patch sent to `allow` it where needed [1]. While that particular case would not be needed after the minimum version bump to 1.85.0, it is simpler to just allow it to prevent future instances. [ In addition, the lint fired without taking into account the features that have been enabled in a crate [2]. While this was improved in Rust 1.90.0 [3], it would still fire in a case like this patch. ] Thus do so, and remove the last instance of locally allowing it we have in the tree (except the one in the vendored `proc_macro2` crate). Note that we still keep the `msrv` config option in `clippy.toml` since that affects other lints as well. Link: https://lore.kernel.org/rust-for-linux/20260404212831.78971-4-jhubbard@nvidia.com/ [1] Link: https://github.com/rust-lang/rust-clippy/issues/14425 [2] Link: https://github.com/rust-lang/rust-clippy/pull/14433 [3] Link: https://patch.msgid.link/20260405235309.418950-8-ojeda@kernel.org Reviewed-by: Gary Guo <gary@garyguo.net> Reviewed-by: Tamir Duberstein <tamird@kernel.org> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>master
parent
b6cfba4366
commit
7ed188605e
1
Makefile
1
Makefile
|
|
@ -486,6 +486,7 @@ export rust_common_flags := --edition=2021 \
|
||||||
-Wclippy::as_underscore \
|
-Wclippy::as_underscore \
|
||||||
-Wclippy::cast_lossless \
|
-Wclippy::cast_lossless \
|
||||||
-Wclippy::ignored_unit_patterns \
|
-Wclippy::ignored_unit_patterns \
|
||||||
|
-Aclippy::incompatible_msrv \
|
||||||
-Wclippy::mut_mut \
|
-Wclippy::mut_mut \
|
||||||
-Wclippy::needless_bitwise_bool \
|
-Wclippy::needless_bitwise_bool \
|
||||||
-Aclippy::needless_lifetimes \
|
-Aclippy::needless_lifetimes \
|
||||||
|
|
|
||||||
|
|
@ -49,7 +49,6 @@ pub(crate) fn file() -> String {
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(CONFIG_RUSTC_HAS_SPAN_FILE)]
|
#[cfg(CONFIG_RUSTC_HAS_SPAN_FILE)]
|
||||||
#[allow(clippy::incompatible_msrv)]
|
|
||||||
{
|
{
|
||||||
proc_macro::Span::call_site().file()
|
proc_macro::Span::call_site().file()
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue