superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

soundwire: bus: Drop dev_pm_domain_detach() call 

Starting with commit f99508074e ("PM: domains: Detach on
device_unbind_cleanup()"), there is no longer a need to call
dev_pm_domain_detach() in the bus remove function. The
device_unbind_cleanup() function now handles this to avoid
invoking devres cleanup handlers while the PM domain is
powered off, which could otherwise lead to failures as
described in the above-mentioned commit.

Drop the explicit dev_pm_domain_detach() call and rely instead
on the flags passed to dev_pm_domain_attach() to power off the
domain.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://lore.kernel.org/r/20250827101506.927787-1-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
pull/1354/merge
Claudiu Beznea 2025-08-27 13:15:06 +03:00 committed by Vinod Koul
parent 8b63fee9f6
commit 969bf687c1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/soundwire/bus_type.c
View File

@ -114,7 +114,6 @@ static int sdw_drv_probe(struct device *dev)
ret = drv->probe(slave, id); ret = drv->probe(slave, id);
if (ret) { if (ret) {
dev_pm_domain_detach(dev, false);
ida_free(&slave->bus->slave_ida, slave->index); ida_free(&slave->bus->slave_ida, slave->index);
return ret; return ret;
} }
@ -180,8 +179,6 @@ static int sdw_drv_remove(struct device *dev)
if (drv->remove) if (drv->remove)
ret = drv->remove(slave); ret = drv->remove(slave);
dev_pm_domain_detach(dev, false);
ida_free(&slave->bus->slave_ida, slave->index); ida_free(&slave->bus->slave_ida, slave->index);
return ret; return ret;