superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: phy: add a PHY write barrier when disabling interrupts 

MDIO bus controllers are not required to wait for write transactions to
complete before returning as synchronization is often achieved by polling
status bits.

This can cause issues when disabling interrupts since an interrupt could
fire before the interrupt handler is unregistered and there's no status
bit to poll.

Add a phy_write_barrier() function and use it in phy_disable_interrupts()
to fix this issue. The write barrier just reads an MII register and
discards the value, which is enough to guarantee that previous writes have
completed.

Signed-off-by: Charles Perry <charles.perry@microchip.com>
Link: https://patch.msgid.link/20260408131821.1145334-4-charles.perry@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
master
Charles Perry 2026-04-08 06:18:16 -07:00 committed by Jakub Kicinski
parent f76aef9802
commit 96aefe3afe
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/net/phy/phy.c
View File

@ -1368,14 +1368,37 @@ void phy_error(struct phy_device *phydev)
}
EXPORT_SYMBOL(phy_error);
/**
* phy_write_barrier - ensure the last write completed for this PHY device
* @phydev: target phy_device struct
*
* MDIO bus controllers are not required to wait for write transactions to
* complete before returning. Calling this function ensures that the previous
* write has completed.
*/
static void phy_write_barrier(struct phy_device *phydev)
{
if (mdiobus_read(phydev->mdio.bus, phydev->mdio.addr, MII_PHYSID1) ==
-EOPNOTSUPP)
mdiobus_c45_read(phydev->mdio.bus, phydev->mdio.addr,
MDIO_MMD_PMAPMD, MII_PHYSID1);
}
/**
* phy_disable_interrupts - Disable the PHY interrupts from the PHY side
* @phydev: target phy_device struct
*/
int phy_disable_interrupts(struct phy_device *phydev)
{
int err;
/* Disable PHY interrupts */
return phy_config_interrupt(phydev, PHY_INTERRUPT_DISABLED);
err = phy_config_interrupt(phydev, PHY_INTERRUPT_DISABLED);
if (err)
return err;
phy_write_barrier(phydev);
return 0;
}
/**