superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

genirq: Use scoped_guard() to shut clang up 

This code pattern trips clang up:

     if (fail)
     	goto undo;

     guard(lock)(lock);
     do_stuff();
     return 0;

undo:
     ...

as it somehow extends the scope of the guard beyond the return statement.

Replace it with a scoped guard to help it to get its act together.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/oe-kbuild-all/202505071809.ajpPxfoZ-lkp@intel.com/
pull/1250/head
Thomas Gleixner 2025-05-07 15:47:06 +02:00
parent aefc11550e
commit 97f4b999e0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/irq/manage.c
View File

@ -2564,8 +2564,8 @@ int request_percpu_nmi(unsigned int irq, irq_handler_t handler,
if (retval)
goto err_irq_setup;
guard(raw_spinlock_irqsave)(&desc->lock);
desc->istate |= IRQS_NMI;
scoped_guard(raw_spinlock_irqsave, &desc->lock)
desc->istate |= IRQS_NMI;
return 0;
err_irq_setup: