superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ACPI: scan: Use acpi_dev_put() in object add error paths 

After acpi_init_device_object(), the lifetime of struct acpi_device is
managed by the driver core through reference counting.

Both acpi_add_power_resource() and acpi_add_single_object() call
acpi_init_device_object() and then invoke acpi_device_add(). If that
fails, their error paths call the release callback directly instead of
dropping the device reference through acpi_dev_put().

This bypasses the normal device lifetime rules and frees the object
without releasing the reference acquired by device_initialize(), which
may lead to a refcount leak.

The issue was identified by a static analysis tool I developed and
confirmed by manual review.

Fix both error paths by using acpi_dev_put() and let the release
callback handle the final cleanup.

Fixes: 781d737c74 ("ACPI: Drop power resources driver")
Fixes: 718fb0de8f ("ACPI: fix NULL bug for HID/UID string")
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Link: https://patch.msgid.link/20260413135343.2884481-1-lgs201920130244@gmail.com
Signed-off-by: Rafael J. Wysocki <rjw@rjwysocki.net>
master
Guangshuo Li 2026-04-13 21:53:43 +08:00 committed by Rafael J. Wysocki
parent 2e31b16101
commit 9c0acc169a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/acpi/power.c
View File

@ -987,7 +987,7 @@ struct acpi_device *acpi_add_power_resource(acpi_handle handle)
return device;
err:
acpi_release_power_resource(&device->dev);
acpi_dev_put(device);
return NULL;
}

2
drivers/acpi/scan.c
View File

@ -1900,7 +1900,7 @@ static int acpi_add_single_object(struct acpi_device **child,
result = acpi_device_add(device);
if (result) {
acpi_device_release(&device->dev);
acpi_dev_put(device);
return result;
}