superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

phy: ti: gmii-sel: Add a sanity check on the phy_id 

The "phy_id" comes from the device tree so it's going to be correct.
But static checkers sometimes complain when we have an upper bounds
check with no lower bounds check.  Also it's a bit unusual that the
lowest valid number is 1 instead of 0 so adding a check could
potentially help someone.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/aPJpB-QI8FMpFGOk@stanley.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
pull/1354/merge
Dan Carpenter 2025-10-17 19:04:23 +03:00 committed by Vinod Koul
parent 1797c6677a
commit 9d3daf9ca3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/phy/ti/phy-gmii-sel.c
View File

@ -341,7 +341,7 @@ static struct phy *phy_gmii_sel_of_xlate(struct device *dev,
if (priv->soc_data->features & BIT(PHY_GMII_SEL_RMII_IO_CLK_EN) && if (priv->soc_data->features & BIT(PHY_GMII_SEL_RMII_IO_CLK_EN) &&
args->args_count < 2) args->args_count < 2)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
if (phy_id > priv->num_ports) if (phy_id < 1 || phy_id > priv->num_ports)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
if (phy_id != priv->if_phys[phy_id - 1].id) if (phy_id != priv->if_phys[phy_id - 1].id)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);