superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

liveupdate: luo_file: don't use invalid list iterator 

If we exit a list_for_each_entry() without hitting a break then the list
iterator points to an offset from the list_head.  It's a non-NULL but
invalid pointer and dereferencing it isn't allowed.

Introduce a new "found" variable to test instead.

Link: https://lkml.kernel.org/r/aSlMc4SS09Re4_xn@stanley.mountain
Fixes: 3ee1d673194e ("liveupdate: luo_file: implement file systems callbacks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202511280420.y9O4fyhX-lkp@intel.com/
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
pull/1354/merge
Dan Carpenter 2025-11-28 10:17:07 +03:00 committed by Andrew Morton
parent aa514a297a
commit b2135d1cb0
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/liveupdate/luo_file.c
View File

@ -554,17 +554,20 @@ int luo_retrieve_file(struct luo_file_set *file_set, u64 token,
{ {
struct liveupdate_file_op_args args = {0}; struct liveupdate_file_op_args args = {0};
struct luo_file *luo_file; struct luo_file *luo_file;
bool found = false;
int err; int err;
if (list_empty(&file_set->files_list)) if (list_empty(&file_set->files_list))
return -ENOENT; return -ENOENT;
list_for_each_entry(luo_file, &file_set->files_list, list) { list_for_each_entry(luo_file, &file_set->files_list, list) {
if (luo_file->token == token) if (luo_file->token == token) {
found = true;
break; break;
}
} }
if (luo_file->token != token) if (!found)
return -ENOENT; return -ENOENT;
guard(mutex)(&luo_file->mutex); guard(mutex)(&luo_file->mutex);