superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iommu/tegra: fix device leak on probe_device() 

Make sure to drop the reference taken to the iommu platform device when
looking up its driver data during probe_device().

Note that commit 9826e393e4 ("iommu/tegra-smmu: Fix missing
put_device() call in tegra_smmu_find") fixed the leak in an error path,
but the reference is still leaking on success.

Fixes: 8918465163 ("memory: Add NVIDIA Tegra memory controller support")
Cc: stable@vger.kernel.org	# 3.19: 9826e393e4
Cc: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
pull/1354/merge
Johan Hovold 2025-10-20 06:53:18 +02:00 committed by Joerg Roedel
parent f916109bf5
commit c08934a612
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/iommu/tegra-smmu.c
View File

@ -830,10 +830,9 @@ static struct tegra_smmu *tegra_smmu_find(struct device_node *np)
return NULL; return NULL;
mc = platform_get_drvdata(pdev); mc = platform_get_drvdata(pdev);
if (!mc) {
put_device(&pdev->dev); put_device(&pdev->dev);
if (!mc)
return NULL; return NULL;
}
return mc->smmu; return mc->smmu;
} }