superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ALSA: usb-audio: us144mkii: Fixes for handshake, MIDI out and cleanup 

Add a handshake value of 0x32, which is required when the device
was previously used by another OS with the official drivers.

Correct the last byte of the MIDI output protocol to 0xe0.

Also, remove the unused DRIVER_VERSION macro.

Signed-off-by: Šerif Rami <ramiserifpersia@gmail.com>
Link: https://patch.msgid.link/20250825072557.7670-1-ramiserifpersia@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
pull/476/head
Šerif Rami 2025-08-25 09:25:57 +02:00 committed by Takashi Iwai
parent c08e42c9a4
commit cdbd2acef2
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/usb/usx2y/us144mkii.c
View File

@ -454,7 +454,7 @@ static int tascam_probe(struct usb_interface *intf,
} }
if (handshake_buf[0] != 0x12 && handshake_buf[0] != 0x16 && if (handshake_buf[0] != 0x12 && handshake_buf[0] != 0x16 &&
handshake_buf[0] != 0x30) { handshake_buf[0] != 0x30 && handshake_buf[0] != 0x32) {
dev_err(&dev->dev, "Unexpected handshake value: 0x%x\n", dev_err(&dev->dev, "Unexpected handshake value: 0x%x\n",
handshake_buf[0]); handshake_buf[0]);
return -ENODEV; return -ENODEV;

1
sound/usb/usx2y/us144mkii.h
View File

@ -15,7 +15,6 @@
#include <sound/rawmidi.h> #include <sound/rawmidi.h>
#define DRIVER_NAME "us144mkii" #define DRIVER_NAME "us144mkii"
#define DRIVER_VERSION "1.7.6"
/* --- USB Device Identification --- */ /* --- USB Device Identification --- */
#define USB_VID_TASCAM 0x0644 #define USB_VID_TASCAM 0x0644

2
sound/usb/usx2y/us144mkii_midi.c
View File

@ -257,7 +257,7 @@ static void tascam_midi_out_work_handler(struct work_struct *work)
if (bytes_to_send < 9) if (bytes_to_send < 9)
memset(buf + bytes_to_send, 0xfd, memset(buf + bytes_to_send, 0xfd,
9 - bytes_to_send); 9 - bytes_to_send);
buf[8] = 0x00; buf[8] = 0xe0;
set_bit(urb_index, &tascam->midi_out_urbs_in_flight); set_bit(urb_index, &tascam->midi_out_urbs_in_flight);
urb->transfer_buffer_length = 9; urb->transfer_buffer_length = 9;