superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net dsa: qca8k: fix usages of device_get_named_child_node() 

The documentation for device_get_named_child_node() mentions this
important point:

"
The caller is responsible for calling fwnode_handle_put() on the
returned fwnode pointer.
"

Add fwnode_handle_put() to avoid leaked references.

Fixes: 1e264f9d29 ("net: dsa: qca8k: add LEDs basic support")
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
pull/893/head
Andy Shevchenko 2024-06-06 19:13:03 +03:00 committed by David S. Miller
parent d37fe4255a
commit d029edefed
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/dsa/qca/qca8k-leds.c
View File

@ -431,8 +431,11 @@ qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int p
init_data.devicename = kasprintf(GFP_KERNEL, "%s:0%d", init_data.devicename = kasprintf(GFP_KERNEL, "%s:0%d",
priv->internal_mdio_bus->id, priv->internal_mdio_bus->id,
port_num); port_num);
if (!init_data.devicename) if (!init_data.devicename) {
fwnode_handle_put(led);
fwnode_handle_put(leds);
return -ENOMEM; return -ENOMEM;
}
ret = devm_led_classdev_register_ext(priv->dev, &port_led->cdev, &init_data); ret = devm_led_classdev_register_ext(priv->dev, &port_led->cdev, &init_data);
if (ret) if (ret)
@ -441,6 +444,7 @@ qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int p
kfree(init_data.devicename); kfree(init_data.devicename);
} }
fwnode_handle_put(leds);
return 0; return 0;
} }
@ -471,9 +475,13 @@ qca8k_setup_led_ctrl(struct qca8k_priv *priv)
* the correct port for LED setup. * the correct port for LED setup.
*/ */
ret = qca8k_parse_port_leds(priv, port, qca8k_port_to_phy(port_num)); ret = qca8k_parse_port_leds(priv, port, qca8k_port_to_phy(port_num));
if (ret) if (ret) {
fwnode_handle_put(port);
fwnode_handle_put(ports);
return ret; return ret;
}
} }
fwnode_handle_put(ports);
return 0; return 0;
} }