superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hv_balloon: do adjust_managed_page_count() when ballooning/un-ballooning 

Unlike virtio_balloon/virtio_mem/xen balloon drivers, Hyper-V balloon driver
does not adjust managed pages count when ballooning/un-ballooning and this leads
to incorrect stats being reported, e.g. unexpected 'free' output.

Note, the calculation in post_status() seems to remain correct: ballooned out
pages are never 'available' and we manually add dm->num_pages_ballooned to
'commited'.

Suggested-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20201202161245.2406143-3-vkuznets@redhat.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
pull/712/merge
Vitaly Kuznetsov 2020-12-02 17:12:45 +01:00 committed by Wei Liu
parent 7f3f227b41
commit d1df458cbf
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hv/hv_balloon.c
View File

@ -1198,6 +1198,7 @@ static void free_balloon_pages(struct hv_dynmem_device *dm,
__ClearPageOffline(pg); __ClearPageOffline(pg);
__free_page(pg); __free_page(pg);
dm->num_pages_ballooned--; dm->num_pages_ballooned--;
adjust_managed_page_count(pg, 1);
} }
} }
@ -1238,8 +1239,10 @@ static unsigned int alloc_balloon_pages(struct hv_dynmem_device *dm,
split_page(pg, get_order(alloc_unit << PAGE_SHIFT)); split_page(pg, get_order(alloc_unit << PAGE_SHIFT));
/* mark all pages offline */ /* mark all pages offline */
for (j = 0; j < alloc_unit; j++) for (j = 0; j < alloc_unit; j++) {
__SetPageOffline(pg + j); __SetPageOffline(pg + j);
adjust_managed_page_count(pg + j, -1);
}
bl_resp->range_count++; bl_resp->range_count++;
bl_resp->range_array[i].finfo.start_page = bl_resp->range_array[i].finfo.start_page =