superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ALSA: usb: scarlett2: Fix missing NULL check 

scarlett2_input_select_ctl_info() sets up the string arrays allocated
via kasprintf(), but it misses NULL checks, which may lead to NULL
dereference Oops.  Let's add the proper NULL check.

Fixes: 8eba063b5b ("ALSA: scarlett2: Simplify linked channel handling")
Link: https://patch.msgid.link/20250731053714.29414-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
pull/1320/head
Takashi Iwai 2025-07-31 07:37:08 +02:00
parent 5e0753df96
commit df485a4b2b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sound/usb/mixer_scarlett2.c
View File

@ -3978,8 +3978,13 @@ static int scarlett2_input_select_ctl_info(
goto unlock; goto unlock;
/* Loop through each input */ /* Loop through each input */
for (i = 0; i < inputs; i++) for (i = 0; i < inputs; i++) {
values[i] = kasprintf(GFP_KERNEL, "Input %d", i + 1); values[i] = kasprintf(GFP_KERNEL, "Input %d", i + 1);
if (!values[i]) {
err = -ENOMEM;
goto unlock;
}
}
err = snd_ctl_enum_info(uinfo, 1, i, err = snd_ctl_enum_info(uinfo, 1, i,
(const char * const *)values); (const char * const *)values);