superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drm/tve200: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-51-u.kleine-koenig@pengutronix.de
pull/806/head
Uwe Kleine-König 2023-05-07 18:26:13 +02:00 committed by Douglas Anderson
parent 84e6da7ad5
commit e2fd3192e2
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpu/drm/tve200/tve200_drv.c
View File

@ -236,7 +236,7 @@ dev_unref:
return ret;
}
static int tve200_remove(struct platform_device *pdev)
static void tve200_remove(struct platform_device *pdev)
{
struct drm_device *drm = platform_get_drvdata(pdev);
struct tve200_drm_dev_private *priv = drm->dev_private;
@ -247,8 +247,6 @@ static int tve200_remove(struct platform_device *pdev)
drm_mode_config_cleanup(drm);
clk_disable_unprepare(priv->pclk);
drm_dev_put(drm);
return 0;
}
static const struct of_device_id tve200_of_match[] = {
@ -264,7 +262,7 @@ static struct platform_driver tve200_driver = {
.of_match_table = of_match_ptr(tve200_of_match),
},
.probe = tve200_probe,
.remove = tve200_remove,
.remove_new = tve200_remove,
};
drm_module_platform_driver(tve200_driver);