superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

misc: bh1770glc: use pm_runtime_resume_and_get() in power_state_store 

pm_runtime_get_sync() may increment the runtime PM usage count even if the
resume fails, which requires an explicit pm_runtime_put_noidle() to balance
it. This driver ignored the return value, risking a usage-count leak on
resume failure.

Replace it with pm_runtime_resume_and_get(), which returns 0 on success and
a negative errno on failure, and only increments the usage count on success.
This simplifies the error path and avoids possible leaks. Also check for
errors explicitly with `if (ret < 0)`.

Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
Link: https://patch.msgid.link/20251030120022.239951-1-vivek.balachandhar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
pull/1354/merge
Vivek BalachandharTN 2025-10-30 12:00:22 +00:00 committed by Greg Kroah-Hartman
parent 05d36a5931
commit ef48f0f19e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/bh1770glc.c
View File

@ -640,7 +640,9 @@ static ssize_t bh1770_power_state_store(struct device *dev,
mutex_lock(&chip->mutex); mutex_lock(&chip->mutex);
if (value) { if (value) {
pm_runtime_get_sync(dev); ret = pm_runtime_resume_and_get(dev);
if (ret < 0)
goto leave;
ret = bh1770_lux_rate(chip, chip->lux_rate_index); ret = bh1770_lux_rate(chip, chip->lux_rate_index);
if (ret < 0) { if (ret < 0) {