superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

irqchip/msi-lib: Honor the MSI_FLAG_PCI_MSI_MASK_PARENT flag 

For systems that implement interrupt masking at the interrupt controller
level, the MSI library offers MSI_FLAG_PCI_MSI_MASK_PARENT.  It indicates
that it isn't enough to only unmask the interrupt at the PCI device level,
but that the interrupt controller must also be involved.

However, the way this is currently done is less than optimal, as the
masking/unmasking is done on both sides, always. It would be far cheaper to
unmask both at the start of times, and then only deal with the interrupt
controller mask, which is cheaper than a round-trip to the PCI endpoint.

Now that the PCI/MSI layer implements irq_startup() and irq_shutdown()
callbacks, which [un]mask at the PCI level and honor the request to
[un]mask the parent, this can be trivially done.

Overwrite the irq_mask/unmask() callbacks of the device domain interrupt
chip with irq_[un]mask_parent() when the parent domain asks for it.

[ tglx: Adopted to the PCI/MSI changes ]

Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/20250903135433.380783272@linutronix.de
pull/1354/merge
Marc Zyngier 2025-09-03 16:04:46 +02:00 committed by Thomas Gleixner
parent b2a0c13f8b
commit f09c1d63e8
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/irqchip/irq-msi-lib.c
View File

@ -112,6 +112,20 @@ bool msi_lib_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
*/ */
if (!chip->irq_set_affinity && !(info->flags & MSI_FLAG_NO_AFFINITY)) if (!chip->irq_set_affinity && !(info->flags & MSI_FLAG_NO_AFFINITY))
chip->irq_set_affinity = msi_domain_set_affinity; chip->irq_set_affinity = msi_domain_set_affinity;
/*
* If the parent domain insists on being in charge of masking, obey
* blindly. The interrupt is un-masked at the PCI level on startup
* and masked on shutdown to prevent rogue interrupts after the
* driver freed the interrupt. Not masking it at the PCI level
* speeds up operation for disable/enable_irq() as it avoids
* getting all the way out to the PCI device.
*/
if (info->flags & MSI_FLAG_PCI_MSI_MASK_PARENT) {
chip->irq_mask = irq_chip_mask_parent;
chip->irq_unmask = irq_chip_unmask_parent;
}
return true; return true;
} }
EXPORT_SYMBOL_GPL(msi_lib_init_dev_msi_info); EXPORT_SYMBOL_GPL(msi_lib_init_dev_msi_info);