superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drbd: use get_random_u64() where appropriate 

Use the typed random integer helpers instead of
get_random_bytes() when filling a single integer variable.
The helpers return the value directly, require no pointer
or size argument, and better express intent.

Signed-off-by: David Carlier <devnexen@gmail.com>
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Link: https://patch.msgid.link/20260405154704.4610-1-devnexen@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
master
David Carlier 2026-04-05 16:47:04 +01:00 committed by Jens Axboe
parent a9c4b1d376
commit fa0cac9a51
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/block/drbd/drbd_main.c
View File

@ -874,7 +874,7 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device *peer_device)
if (uuid && uuid != UUID_JUST_CREATED) if (uuid && uuid != UUID_JUST_CREATED)
uuid = uuid + UUID_NEW_BM_OFFSET; uuid = uuid + UUID_NEW_BM_OFFSET;
else else
get_random_bytes(&uuid, sizeof(u64)); uuid = get_random_u64();
drbd_uuid_set(device, UI_BITMAP, uuid); drbd_uuid_set(device, UI_BITMAP, uuid);
drbd_print_uuids(device, "updated sync UUID"); drbd_print_uuids(device, "updated sync UUID");
drbd_md_sync(device); drbd_md_sync(device);
@ -3337,7 +3337,7 @@ void drbd_uuid_new_current(struct drbd_device *device) __must_hold(local)
u64 val; u64 val;
unsigned long long bm_uuid; unsigned long long bm_uuid;
get_random_bytes(&val, sizeof(u64)); val = get_random_u64();
spin_lock_irq(&device->ldev->md.uuid_lock); spin_lock_irq(&device->ldev->md.uuid_lock);
bm_uuid = device->ldev->md.uuid[UI_BITMAP]; bm_uuid = device->ldev->md.uuid[UI_BITMAP];

2
drivers/block/drbd/drbd_nl.c
View File

@ -3236,7 +3236,7 @@ int drbd_adm_resume_io(struct sk_buff *skb, struct genl_info *info)
* matching real data uuid exists). * matching real data uuid exists).
*/ */
u64 val; u64 val;
get_random_bytes(&val, sizeof(u64)); val = get_random_u64();
drbd_set_ed_uuid(device, val); drbd_set_ed_uuid(device, val);
drbd_warn(device, "Resumed without access to data; please tear down before attempting to re-configure.\n"); drbd_warn(device, "Resumed without access to data; please tear down before attempting to re-configure.\n");
} }