Joao Martins ba090c6deb vfio/iova_bitmap: refactor iova_bitmap_set() to better handle page boundaries ... [ Upstream commit b058ea3ab5 ] Commit f38044e5ef ("vfio/iova_bitmap: Fix PAGE_SIZE unaligned bitmaps") had fixed the unaligned bitmaps by capping the remaining iterable set at the start of the bitmap. Although, that mistakenly worked around iova_bitmap_set() incorrectly setting bits across page boundary. Fix this by reworking the loop inside iova_bitmap_set() to iterate over a range of bits to set (cur_bit .. last_bit) which may span different pinned pages, thus updating @page_idx and @offset as it sets the bits. The previous cap to the first page is now adjusted to be always accounted rather than when there's only a non-zero pgoff. While at it, make @page_idx , @offset and @nbits to be unsigned int given that it won't be more than 512 and 4096 respectively (even a bigger PAGE_SIZE or a smaller struct page size won't make this bigger than the above 32-bit max). Also, delete the stale kdoc on Return type. Cc: Avihai Horon <avihaih@nvidia.com> Fixes: f38044e5ef ("vfio/iova_bitmap: Fix PAGE_SIZE unaligned bitmaps") Co-developed-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Joao Martins <joao.m.martins@oracle.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Tested-by: Avihai Horon <avihaih@nvidia.com> Link: https://lore.kernel.org/r/20221129131235.38880-1-joao.m.martins@oracle.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-12-31 13:32:41 +01:00
..
fsl-mc	vfio/fsl-mc: Use the new device life cycle helpers	2022-09-21 14:15:11 -06:00
mdev	vfio/mdev: add mdev available instance checking to the core	2022-10-04 12:06:58 -06:00
pci	vfio/pci: Check the device set open count on reset	2022-11-10 12:03:36 -07:00
platform	vfio: platform: Do not pass return buffer to ACPI _RST method	2022-12-31 13:32:38 +01:00
Kconfig	vfio: Introduce the DMA logging feature support	2022-09-08 12:59:00 -06:00
Makefile	vfio: Move container code into drivers/vfio/container.c	2022-09-22 15:46:06 -06:00
container.c	vfio: Change vfio_group->group_rwsem to a mutex	2022-10-04 12:06:58 -06:00
iova_bitmap.c	vfio/iova_bitmap: refactor iova_bitmap_set() to better handle page boundaries	2022-12-31 13:32:41 +01:00
vfio.h	vfio: Make the group FD disassociate from the iommu_group	2022-10-07 08:10:52 -06:00
vfio_iommu_spapr_tce.c	vfio/spapr_tce: Fix the comment	2022-07-22 16:24:47 -06:00
vfio_iommu_type1.c	Merge branches 'apple/dart', 'arm/mediatek', 'arm/omap', 'arm/smmu', 'virtio', 'x86/vt-d', 'x86/amd' and 'core' into next	2022-09-26 15:52:31 +02:00
vfio_main.c	vfio: Export the device set open count	2022-11-10 12:03:36 -07:00
vfio_spapr_eeh.c	…
virqfd.c	vfio/virqfd: Drain events from eventfd in virqfd_wakeup()	2020-11-15 09:49:10 -05:00