superrob1500
/
mirror-linux
mirror of https://github.com/torvalds/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
mirror-linux/drivers/mtd/ubi
History
Wang YanQing 884e961674 ubi: Fix return value overwrite issue in try_write_vid_and_data() 
commit 31a149d5c1 upstream.

The commit 2d78aee426 ("UBI: simplify LEB write and atomic LEB change code")
adds helper function, try_write_vid_and_data(), to simplify the code, but this
helper function has bug, it will return 0 (success) when ubi_io_write_vid_hdr()
or the ubi_io_write_data() return error number (-EIO, etc), because the return
value of ubi_wl_put_peb() will overwrite the original return value.

This issue will cause unexpected data loss issue, because the caller of this
function and UBIFS willn't know the data is lost.

Fixes: 2d78aee426 ("UBI: simplify LEB write and atomic LEB change code")
Cc: stable@vger.kernel.org
Signed-off-by: Wang YanQing <udknight@gmail.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2023-05-11 23:03:05 +09:00
..
Kconfig
…
Makefile
…
attach.c
…
block.c ubi: block: Fix typos in comments 2022-09-21 11:32:27 +02:00
build.c ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size 2023-04-20 12:35:13 +02:00
cdev.c ubi: fastmap: Add fastmap control support for 'UBI_IOCATT' ioctl 2022-09-21 18:29:18 +02:00
debug.c treewide: use prandom_u32_max() when possible, part 1 2022-10-11 17:42:55 -06:00
debug.h treewide: use prandom_u32_max() when possible, part 1 2022-10-11 17:42:55 -06:00
eba.c ubi: Fix return value overwrite issue in try_write_vid_and_data() 2023-05-11 23:03:05 +09:00
fastmap-wl.c ubi: fastmap: Fix missed fm_anchor PEB in wear-leveling after disabling fastmap 2023-03-11 13:55:21 +01:00
fastmap.c ubi: fastmap: Use the bitmap API to allocate bitmaps 2022-09-21 11:32:58 +02:00
gluebi.c
…
io.c ubi: Fix repeated words in comments 2022-09-21 11:32:27 +02:00
kapi.c
…
misc.c
…
ubi-media.h ubi: ubi-media.h: Fix comment typo 2022-09-21 11:12:18 +02:00
ubi.h ubi: fastmap: Add fastmap control support for 'UBI_IOCATT' ioctl 2022-09-21 18:29:18 +02:00
upd.c
…
vmt.c ubi: Fix possible null-ptr-deref in ubi_free_volume() 2023-03-11 13:55:20 +01:00
vtbl.c
…
wl.c ubi: Fix deadlock caused by recursively holding work_sem 2023-04-20 12:35:14 +02:00
wl.h
…