H. Nikolaus Schaller 873fff9fd6 PCI: imx6: Install the fault handler only on compatible match ... [ Upstream commit 5f5ac460df ] commit bb38919ec5 ("PCI: imx6: Add support for i.MX6 PCIe controller") added a fault hook to this driver in the probe function. So it was only installed if needed. commit bde4a5a00e ("PCI: imx6: Allow probe deferral by reset GPIO") moved it from probe to driver init which installs the hook unconditionally as soon as the driver is compiled into a kernel. When this driver is compiled as a module, the hook is not registered until after the driver has been matched with a .compatible and loaded. commit 415b6185c5 ("PCI: imx6: Fix config read timeout handling") extended the fault handling code. commit 2d8ed461db ("PCI: imx6: Add support for i.MX8MQ") added some protection for non-ARM architectures, but this does not protect non-i.MX ARM architectures. Since fault handlers can be triggered on any architecture for different reasons, there is no guarantee that they will be triggered only for the assumed situation, leading to improper error handling (i.MX6-specific imx6q_pcie_abort_handler) on foreign systems. I had seen strange L3 imprecise external abort messages several times on OMAP4 and OMAP5 devices and couldn't make sense of them until I realized they were related to this unused imx6q driver because I had CONFIG_PCI_IMX6=y. Note that CONFIG_PCI_IMX6=y is useful for kernel binaries that are designed to run on different ARM SoC and be differentiated only by device tree binaries. So turning off CONFIG_PCI_IMX6 is not a solution. Therefore we check the compatible in the init function before registering the fault handler. Link: https://lore.kernel.org/r/e1bcfc3078c82b53aa9b78077a89955abe4ea009.1678380991.git.hns@goldelico.com Fixes: bde4a5a00e ("PCI: imx6: Allow probe deferral by reset GPIO") Fixes: 415b6185c5 ("PCI: imx6: Fix config read timeout handling") Fixes: 2d8ed461db ("PCI: imx6: Add support for i.MX8MQ") Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-11 23:03:28 +09:00
..
Kconfig	PCI: kirin: Select REGMAP_MMIO	2023-05-11 23:02:59 +09:00
Makefile	…
pci-dra7xx.c	…
pci-exynos.c	…
pci-imx6.c	PCI: imx6: Install the fault handler only on compatible match	2023-05-11 23:03:28 +09:00
pci-keystone.c	…
pci-layerscape-ep.c	…
pci-layerscape.c	…
pci-meson.c	…
pcie-al.c	…
pcie-armada8k.c	…
pcie-artpec6.c	…
pcie-designware-ep.c	…
pcie-designware-host.c	…
pcie-designware-plat.c	…
pcie-designware.c	PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled	2023-04-06 12:10:43 +02:00
pcie-designware.h	…
pcie-dw-rockchip.c	…
pcie-fu740.c	…
pcie-hisi.c	…
pcie-histb.c	…
pcie-intel-gw.c	…
pcie-keembay.c	…
pcie-kirin.c	…
pcie-qcom-ep.c	…
pcie-qcom.c	PCI: qcom: Fix the incorrect register usage in v2.7.0 config	2023-05-11 23:02:59 +09:00
pcie-spear13xx.c	…
pcie-tegra194-acpi.c	…
pcie-tegra194.c	…
pcie-uniphier-ep.c	…
pcie-uniphier.c	…
pcie-visconti.c	…