Dmitry Bogdanov a7a4def6c7 scsi: target: iscsit: Free cmds before session free ... [ Upstream commit d8990b5a4d ] Commands from recovery entries are freed after session has been closed. That leads to use-after-free at command free or NPE with such call trace: Time2Retain timer expired for SID: 1, cleaning up iSCSI session. BUG: kernel NULL pointer dereference, address: 0000000000000140 RIP: 0010:sbitmap_queue_clear+0x3a/0xa0 Call Trace: target_release_cmd_kref+0xd1/0x1f0 [target_core_mod] transport_generic_free_cmd+0xd1/0x180 [target_core_mod] iscsit_free_cmd+0x53/0xd0 [iscsi_target_mod] iscsit_free_connection_recovery_entries+0x29d/0x320 [iscsi_target_mod] iscsit_close_session+0x13a/0x140 [iscsi_target_mod] iscsit_check_post_dataout+0x440/0x440 [iscsi_target_mod] call_timer_fn+0x24/0x140 Move cleanup of recovery enrties to before session freeing. Reported-by: Forza <forza@tnonline.net> Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com> Signed-off-by: Mike Christie <michael.christie@oracle.com> Link: https://lore.kernel.org/r/20230319015620.96006-7-michael.christie@oracle.com Reviewed-by: Maurizio Lombardi <mlombard@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-24 17:32:37 +01:00
..
cxgbit	…
Kconfig	…
Makefile	…
iscsi_target.c	scsi: target: iscsit: Free cmds before session free	2023-05-24 17:32:37 +01:00
iscsi_target.h	…
iscsi_target_auth.c	…
iscsi_target_auth.h	…
iscsi_target_configfs.c	…
iscsi_target_datain_values.c	…
iscsi_target_datain_values.h	…
iscsi_target_device.c	…
iscsi_target_device.h	…
iscsi_target_erl0.c	…
iscsi_target_erl0.h	…
iscsi_target_erl1.c	…
iscsi_target_erl1.h	…
iscsi_target_erl2.c	…
iscsi_target_erl2.h	…
iscsi_target_login.c	scsi: target: iscsit: isert: Alloc per conn cmd counter	2023-05-11 23:03:19 +09:00
iscsi_target_login.h	…
iscsi_target_nego.c	…
iscsi_target_nego.h	…
iscsi_target_nodeattrib.c	…
iscsi_target_nodeattrib.h	…
iscsi_target_parameters.c	…
iscsi_target_parameters.h	…
iscsi_target_seq_pdu_list.c	…
iscsi_target_seq_pdu_list.h	…
iscsi_target_stat.c	…
iscsi_target_tmr.c	…
iscsi_target_tmr.h	…
iscsi_target_tpg.c	…
iscsi_target_tpg.h	…
iscsi_target_transport.c	…
iscsi_target_util.c	…
iscsi_target_util.h	…