mirror-linux/sound/soc/sof/intel
Pierre-Louis Bossart 6d0ab3efb2 ASoC: SOF: Intel: pci-tng: revert invalid bar size setting
[ Upstream commit ca09e2a351 ]

The logic for the ioremap is to find the resource index 3 (IRAM) and
infer the BAR address by subtracting the IRAM offset. The BAR size
defined in hardware specifications is 2MB.

The commit 5947b2726b ("ASoC: SOF: Intel: Check the bar size before
remapping") tried to find the BAR size by querying the resource length
instead of a pre-canned value, but by requesting the size for index 3
it only gets the size of the IRAM. That's obviously wrong and prevents
the probe from proceeding.

This commit attempted to fix an issue in a fuzzing/simulated
environment but created another on actual devices, so the best course
of action is to revert that change.

Reported-by: Ferry Toth <fntoth@gmail.com>
Tested-by: Ferry Toth <fntoth@gmail.com> (Intel Edison-Arduino)
Link: https://github.com/thesofproject/linux/issues/3901
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230307095341.3222-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-06 12:10:38 +02:00
..
Kconfig ASoC: SOF: Intel: add initial SKL/KBL hardware support 2022-09-20 19:07:30 +01:00
Makefile ASoC: SOF: Intel: add initial SKL/KBL hardware support 2022-09-20 19:07:30 +01:00
apl.c ASoC: SOF: ipc4/Intel: Improve and enable IPC error dump 2022-09-23 20:46:25 +01:00
atom.c ASoC: SOF: Intel: atom: don't keep a temporary string in fixup_tplg_name 2022-07-15 20:11:35 +01:00
atom.h
bdw.c
byt.c ASoC: SOF: Intel: byt: remove duplicating driver data retrieval 2022-07-05 19:54:03 +01:00
cnl.c ASoC: SOF: ipc4/Intel: Improve and enable IPC error dump 2022-09-23 20:46:25 +01:00
ext_manifest.h
hda-bus.c
hda-codec.c ASoC: SOF: Intel: hda-codec: fix possible memory leak in hda_codec_device_init() 2022-10-21 13:04:14 +01:00
hda-common-ops.c
hda-ctrl.c
hda-dai.c ASoC: SOF: Intel: hda-dai: fix possible stream_tag leak 2023-02-22 12:59:56 +01:00
hda-dsp.c ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed" 2023-01-12 12:02:43 +01:00
hda-ipc.c ASoC: SOF: Intel: add initial SKL/KBL hardware support 2022-09-20 19:07:30 +01:00
hda-ipc.h ASoC: SOF: Intel: cnl: Add separate ops for ipc_dump for IPC4 2022-09-23 14:53:17 +01:00
hda-loader-skl.c ASoC: SOF: Intel: add initial SKL/KBL hardware support 2022-09-20 19:07:30 +01:00
hda-loader.c ASoC: SOF: Intel: hda-loader: Use the FSR state definitions during bootup 2022-08-23 14:10:01 +01:00
hda-pcm.c ASoC: SOF: Intel: replace dev_vdbg with tracepoints 2022-09-19 15:44:06 +01:00
hda-probes.c ASoC: SOF: probes: rename assign/free callbacks as startup/shutdown 2022-07-15 20:11:38 +01:00
hda-stream.c ASoC: SOF: Intel: replace dev_vdbg with tracepoints 2022-09-19 15:44:06 +01:00
hda-trace.c
hda.c ASoC: SOF: ipc4/Intel: Improve and enable IPC error dump 2022-09-23 20:46:25 +01:00
hda.h ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed" 2023-01-12 12:02:43 +01:00
icl.c ASoC: SOF: ipc4/Intel: Improve and enable IPC error dump 2022-09-23 20:46:25 +01:00
mtl.c ASoC: SOF: ipc4/Intel: Improve and enable IPC error dump 2022-09-23 20:46:25 +01:00
mtl.h
pci-apl.c ASoC: SOF: Intel: HDA: Fix device description 2023-03-22 13:33:40 +01:00
pci-cnl.c ASoC: SOF: Intel: HDA: Fix device description 2023-03-22 13:33:40 +01:00
pci-icl.c ASoC: SOF: Intel: HDA: Fix device description 2023-03-22 13:33:40 +01:00
pci-mtl.c ASoC: SOF: Intel: MTL: Fix the device description 2023-03-22 13:33:40 +01:00
pci-skl.c ASoC: SOF: Intel: SKL: Fix device description 2023-03-22 13:33:40 +01:00
pci-tgl.c ASOC: SOF: Intel: pci-tgl: Fix device description 2023-03-22 13:33:40 +01:00
pci-tng.c ASoC: SOF: Intel: pci-tng: revert invalid bar size setting 2023-04-06 12:10:38 +02:00
shim.h ASoC: SOF: Intel: Add a new op for disabling interrupts 2022-09-23 13:56:16 +01:00
skl.c ASoC: SOF: ipc4/Intel: Improve and enable IPC error dump 2022-09-23 20:46:25 +01:00
tgl.c ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed" 2023-01-12 12:02:43 +01:00