mirror-linux/drivers/gpu/drm/scheduler
Pierre-Eric Pelloux-Prayer b2b8af21fe drm/sched: Fix racy access to drm_sched_entity.dependency
The drm_sched_job_unschedulable trace point can access
entity->dependency after it was cleared by the callback
installed in drm_sched_entity_add_dependency_cb, causing:

BUG: kernel NULL pointer dereference, address: 0000000000000020
[...]
Workqueue: comp_1.1.0 drm_sched_run_job_work [gpu_sched]
RIP: 0010:trace_event_raw_event_drm_sched_job_unschedulable+0x70/0xd0 [gpu_sched]

To fix this we either need to keep a reference to the fence before
setting up the callbacks, or move the trace_drm_sched_job_unschedulable
calls into drm_sched_entity_add_dependency_cb where they can be
done earlier.

Fixes: 76d97c870f ("drm/sched: Trace dependencies for GPU jobs")

Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250901124032.1955-1-pierre-eric.pelloux-prayer@amd.com
2025-09-02 09:25:51 +02:00
..
tests drm/sched/tests: Remove redundant header files 2025-08-28 10:13:56 +02:00
.kunitconfig drm/sched: Add scheduler unit testing infrastructure and some basic tests 2025-03-24 10:41:52 +01:00
Makefile drm/sched: Add scheduler unit testing infrastructure and some basic tests 2025-03-24 10:41:52 +01:00
gpu_scheduler_trace.h drm/doc: Document some tracepoints as uAPI 2025-05-28 16:16:18 +02:00
sched_entity.c drm/sched: Fix racy access to drm_sched_entity.dependency 2025-09-02 09:25:51 +02:00
sched_fence.c drm/scheduler: Include <linux/export.h> 2025-06-16 09:02:41 +02:00
sched_internal.h drm/sched: Store the drm client_id in drm_sched_fence 2025-05-28 16:15:58 +02:00
sched_main.c drm/sched: Document race condition in drm_sched_fini() 2025-08-28 10:27:18 +02:00