Mirsad Goran Todorovac 48e1560230 test_firmware: fix the memory leak of the allocated firmware buffer ... The following kernel memory leak was noticed after running tools/testing/selftests/firmware/fw_run_tests.sh: [root@pc-mtodorov firmware]# cat /sys/kernel/debug/kmemleak . . . unreferenced object 0xffff955389bc3400 (size 1024): comm "test_firmware-0", pid 5451, jiffies 4294944822 (age 65.652s) hex dump (first 32 bytes): 47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567.......... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0 [<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240 [<ffffffff962704de>] kmalloc_trace+0x2e/0xc0 [<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180 [<ffffffff95fd813b>] kthread+0x10b/0x140 [<ffffffff95e033e9>] ret_from_fork+0x29/0x50 unreferenced object 0xffff9553c334b400 (size 1024): comm "test_firmware-1", pid 5452, jiffies 4294944822 (age 65.652s) hex dump (first 32 bytes): 47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567.......... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0 [<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240 [<ffffffff962704de>] kmalloc_trace+0x2e/0xc0 [<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180 [<ffffffff95fd813b>] kthread+0x10b/0x140 [<ffffffff95e033e9>] ret_from_fork+0x29/0x50 unreferenced object 0xffff9553c334f000 (size 1024): comm "test_firmware-2", pid 5453, jiffies 4294944822 (age 65.652s) hex dump (first 32 bytes): 47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567.......... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0 [<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240 [<ffffffff962704de>] kmalloc_trace+0x2e/0xc0 [<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180 [<ffffffff95fd813b>] kthread+0x10b/0x140 [<ffffffff95e033e9>] ret_from_fork+0x29/0x50 unreferenced object 0xffff9553c3348400 (size 1024): comm "test_firmware-3", pid 5454, jiffies 4294944822 (age 65.652s) hex dump (first 32 bytes): 47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567.......... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0 [<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240 [<ffffffff962704de>] kmalloc_trace+0x2e/0xc0 [<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180 [<ffffffff95fd813b>] kthread+0x10b/0x140 [<ffffffff95e033e9>] ret_from_fork+0x29/0x50 [root@pc-mtodorov firmware]# Note that the size 1024 corresponds to the size of the test firmware buffer. The actual number of the buffers leaked is around 70-110, depending on the test run. The cause of the leak is the following: request_partial_firmware_into_buf() and request_firmware_into_buf() provided firmware buffer isn't released on release_firmware(), we have allocated it and we are responsible for deallocating it manually. This is introduced in a number of context where previously only release_firmware() was called, which was insufficient. Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> Fixes: 7feebfa487 ("test_firmware: add support for request_firmware_into_buf") Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Dan Carpenter <error27@gmail.com> Cc: Takashi Iwai <tiwai@suse.de> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: Russ Weight <russell.h.weight@intel.com> Cc: Tianfei zhang <tianfei.zhang@intel.com> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: Zhengchao Shao <shaozhengchao@huawei.com> Cc: Colin Ian King <colin.i.king@gmail.com> Cc: linux-kernel@vger.kernel.org Cc: Kees Cook <keescook@chromium.org> Cc: Scott Branden <sbranden@broadcom.com> Cc: Luis R. Rodriguez <mcgrof@kernel.org> Cc: linux-kselftest@vger.kernel.org Cc: stable@vger.kernel.org # v5.4 Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> Link: https://lore.kernel.org/r/20230509084746.48259-3-mirsad.todorovac@alu.unizg.hr Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-05-31 20:31:07 +01:00
..
842	…
crypto	modules-6.4-rc1	2023-04-27 16:36:55 -07:00
dim	linux/dim: Do nothing if no time delta between samples	2023-05-09 11:06:45 +02:00
fonts	…
kunit	kunit: add tests for using current KUnit test field	2023-04-05 12:51:30 -06:00
livepatch	…
lz4	…
lzo	…
math	…
mpi	…
pldmfw	lib: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:53 -07:00
raid6	…
reed_solomon	…
test_fortify	…
vdso	…
xz	…
zlib_deflate	…
zlib_dfltcc	…
zlib_inflate	…
zstd	…
.gitignore	…
Kconfig	Kconfig: introduce HAS_IOPORT option and select it as necessary	2023-04-05 22:15:19 +02:00
Kconfig.debug	s390 updates for the 6.4 merge window	2023-04-30 11:43:31 -07:00
Kconfig.kasan	…
Kconfig.kcsan	…
Kconfig.kfence	…
Kconfig.kgdb	…
Kconfig.kmsan	…
Kconfig.ubsan	…
Makefile	modules-6.4-rc1	2023-04-27 16:36:55 -07:00
argv_split.c	…
ashldi3.c	…
ashrdi3.c	…
asn1_decoder.c	…
asn1_encoder.c	…
assoc_array.c	…
atomic64.c	…
atomic64_test.c	…
audit.c	…
base64.c	…
bcd.c	…
bch.c	…
bitfield_kunit.c	…
bitmap.c	…
bitrev.c	…
bootconfig-data.S	…
bootconfig.c	…
bsearch.c	…
btree.c	btree: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:54 -07:00
bucket_locks.c	…
bug.c	…
build_OID_registry	…
buildid.c	ELF: fix all "Elf" typos	2023-04-08 13:45:37 -07:00
bust_spinlocks.c	…
check_signature.c	…
checksum.c	…
clz_ctz.c	…
clz_tab.c	…
cmdline.c	…
cmdline_kunit.c	…
cmpdi2.c	…
compat_audit.c	…
cpu_rmap.c	…
cpumask.c	…
cpumask_kunit.c	…
crc-ccitt.c	…
crc-itu-t.c	…
crc-t10dif.c	…
crc4.c	…
crc7.c	…
crc8.c	…
crc16.c	…
crc32.c	…
crc32defs.h	…
crc32test.c	…
crc64-rocksoft.c	…
crc64.c	…
ctype.c	…
debug_info.c	…
debug_locks.c	…
debugobjects.c	debugobjects: Don't wake up kswapd from fill_pool()	2023-05-22 14:52:58 +02:00
dec_and_lock.c	…
decompress.c	…
decompress_bunzip2.c	…
decompress_inflate.c	…
decompress_unlz4.c	…
decompress_unlzma.c	…
decompress_unlzo.c	…
decompress_unxz.c	…
decompress_unzstd.c	…
devmem_is_allowed.c	…
devres.c	…
dhry.h	…
dhry_1.c	…
dhry_2.c	…
dhry_run.c	…
digsig.c	…
dump_stack.c	…
dynamic_debug.c	…
dynamic_queue_limits.c	…
earlycpio.c	…
errname.c	…
error-inject.c	…
errseq.c	…
extable.c	…
fault-inject-usercopy.c	…
fault-inject.c	fault-inject: allow configuration via configfs	2023-04-13 07:38:54 -06:00
fdt.c	…
fdt_addresses.c	…
fdt_empty_tree.c	…
fdt_ro.c	…
fdt_rw.c	…
fdt_strerror.c	…
fdt_sw.c	…
fdt_wip.c	…
find_bit.c	…
find_bit_benchmark.c	…
flex_proportions.c	…
fortify_kunit.c	…
gen_crc32table.c	…
gen_crc64table.c	…
genalloc.c	…
generic-radix-tree.c	…
glob.c	…
globtest.c	…
group_cpus.c	lib/group_cpus: Export group_cpus_evenly()	2023-04-21 03:02:31 -04:00
hashtable_test.c	…
hexdump.c	…
hweight.c	…
idr.c	…
inflate.c	…
interval_tree.c	…
interval_tree_test.c	…
iomap.c	…
iomap_copy.c	…
iommu-helper.c	…
iov_iter.c	mm: hwpoison: coredump: support recovery from dump_user_range()	2023-05-02 17:21:50 -07:00
irq_poll.c	…
irq_regs.c	…
is_signed_type_kunit.c	…
is_single_threaded.c	…
kasprintf.c	…
kfifo.c	…
klist.c	…
kobject.c	…
kobject_uevent.c	…
kstrtox.c	…
kstrtox.h	…
libcrc32c.c	libcrc32c: remove crc32c_impl	2023-04-17 18:01:23 +02:00
linear_ranges.c	…
list-test.c	list: test: Test the klist structure	2023-03-31 09:21:35 -06:00
list_debug.c	…
list_sort.c	…
llist.c	…
locking-selftest-hardirq.h	…
locking-selftest-mutex.h	…
locking-selftest-rlock-hardirq.h	…
locking-selftest-rlock-softirq.h	…
locking-selftest-rlock.h	…
locking-selftest-rsem.h	…
locking-selftest-rtmutex.h	…
locking-selftest-softirq.h	…
locking-selftest-spin-hardirq.h	…
locking-selftest-spin-softirq.h	…
locking-selftest-spin.h	…
locking-selftest-wlock-hardirq.h	…
locking-selftest-wlock-softirq.h	…
locking-selftest-wlock.h	…
locking-selftest-wsem.h	…
locking-selftest.c	…
lockref.c	…
logic_iomem.c	…
logic_pio.c	…
lru_cache.c	…
lshrdi3.c	…
maple_tree.c	maple_tree: make maple state reusable after mas_empty_area()	2023-05-17 15:24:32 -07:00
memcat_p.c	…
memcpy_kunit.c	…
memory-notifier-error-inject.c	…
memregion.c	…
memweight.c	…
muldi3.c	…
net_utils.c	…
netdev-notifier-error-inject.c	…
nlattr.c	…
nmi_backtrace.c	…
notifier-error-inject.c	…
notifier-error-inject.h	…
objagg.c	…
of-reconfig-notifier-error-inject.c	…
oid_registry.c	…
once.c	…
overflow_kunit.c	…
packing.c	…
parman.c	…
parser.c	…
pci_iomap.c	…
percpu-refcount.c	…
percpu_counter.c	…
percpu_test.c	…
plist.c	…
pm-notifier-error-inject.c	…
polynomial.c	…
radix-tree.c	…
random32.c	…
ratelimit.c	…
rbtree.c	lib/rbtree: use '+' instead of '|' for setting color.	2023-04-18 16:39:33 -07:00
rbtree_test.c	…
rcuref.c	…
ref_tracker.c	…
refcount.c	…
rhashtable.c	…
sbitmap.c	…
scatterlist.c	…
seq_buf.c	seq_buf: Add seq_buf_do_printk() helper	2023-04-25 21:03:14 -04:00
sg_pool.c	…
sg_split.c	…
show_mem.c	lib/show_mem.c: use for_each_populated_zone() simplify code	2023-04-21 14:52:02 -07:00
siphash.c	…
siphash_kunit.c	…
slub_kunit.c	…
smp_processor_id.c	…
sort.c	…
stackdepot.c	lib/stackdepot: kmsan: mark API outputs as initialized	2023-03-28 16:20:13 -07:00
stackinit_kunit.c	…
stmp_device.c	…
string.c	…
string_helpers.c	…
strncpy_from_user.c	…
strnlen_user.c	…
strscpy_kunit.c	…
syscall.c	…
test-kstrtox.c	…
test-string_helpers.c	lib/test-string_helpers: replace UNESCAPE_ANY by UNESCAPE_ALL_MASK	2023-04-08 13:45:39 -07:00
test_bitmap.c	…
test_bitops.c	…
test_bits.c	…
test_blackhole_dev.c	…
test_bpf.c	…
test_debug_virtual.c	…
test_dynamic_debug.c	…
test_firmware.c	test_firmware: fix the memory leak of the allocated firmware buffer	2023-05-31 20:31:07 +01:00
test_fprobe.c	tracing updates for 6.4:	2023-04-28 15:57:53 -07:00
test_fpu.c	…
test_free_pages.c	…
test_hash.c	…
test_hexdump.c	…
test_hmm.c	…
test_hmm_uapi.h	…
test_ida.c	…
test_kmod.c	…
test_kprobes.c	…
test_linear_ranges.c	…
test_list_sort.c	…
test_lockup.c	…
test_maple_tree.c	…
test_memcat_p.c	…
test_meminit.c	…
test_min_heap.c	…
test_module.c	…
test_objagg.c	…
test_parman.c	…
test_printf.c	…
test_ref_tracker.c	…
test_rhashtable.c	…
test_scanf.c	…
test_sort.c	…
test_static_key_base.c	…
test_static_keys.c	…
test_string.c	…
test_sysctl.c	…
test_ubsan.c	…
test_user_copy.c	…
test_uuid.c	…
test_vmalloc.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
test_xarray.c	…
textsearch.c	…
timerqueue.c	…
trace_readwrite.c	…
ts_bm.c	…
ts_fsm.c	…
ts_kmp.c	…
ubsan.c	…
ubsan.h	…
ucmpdi2.c	…
ucs2_string.c	…
usercopy.c	…
uuid.c	…
vsprintf.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
win_minmax.c	…
xarray.c	…
xxhash.c	…